A lot of misc changes to extern types#1
Merged
canndrew merged 8 commits intocanndrew:extern-typesfrom Jan 21, 2017
Merged
Conversation
- niether -> neither - Use actual em dash
Owner
|
Thanks! These are some good changes. |
canndrew
pushed a commit
that referenced
this pull request
Dec 23, 2017
canndrew
pushed a commit
that referenced
this pull request
Dec 3, 2018
canndrew
pushed a commit
that referenced
this pull request
Dec 3, 2018
rfc, const-repeat-expr: notes on is_rvalue_promotable(expr)
canndrew
pushed a commit
that referenced
this pull request
Dec 3, 2018
golddranks
referenced
this pull request
in golddranks/rfcs
Nov 3, 2019
RFC 2582: Fix typo (must not -> need not)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit I did reformatted to be one sentance per line (see rust-lang#1811). I did this to minimize diffs, but then mostly added code, so below we get the opposite effect in practice. So I'd be happy to undo that part. (Or, ust merge the first commit and then look at the diff.)
Also, feel free to steal from this rather than merge it wholesale, thanks again for writing this RFC!