fix build wrt to ocaml PR#881#118
Merged
1 commit merged intocamlp4:trunkfrom Jan 4, 2017
v-gb:update-wrt-ocaml-881
Merged
Conversation
Collaborator
|
(I wrote a comment but I misunderstood: @sliquister knows that this file should print in revised syntax, precisely the previous code did not respect that in this case.) |
Collaborator
|
@diml: I just merged the OCaml-side change upstream, could you merge this one quickly enough, so that the CI does not stay broken for too long? |
gasche
added a commit
to ocaml/ocaml
that referenced
this pull request
Jan 2, 2017
|
Merged. @gasche, in the future feel free to merge PRs for Camlp4 to avoid breaking the OCaml CI. I don't usually read my mails when I'm not at work |
Collaborator
I think that's an excellent practice. (I don't think I have commit rights to camlp4 though.) |
gasche
added a commit
to ocaml/ocaml
that referenced
this pull request
Jan 4, 2017
|
Indeed, I added you to the repo |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how to run that code but the old code looks buggy, it's printing ['a t] instead of [t 'a] as the new code does.