Flow review - BYON#27
Conversation
|
Starting with changes on the Notification process following shared MoMs |
|
Updated documentation, registration / notification diagram considered done. |
Updated CallHandlig yaml
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Minutes of Meetings
|
Updated after today's meeting. Really appreciate feedback on salmon notes of the diagram. |
|
Also considering splitting Registration(RACM) / Notification / CallHandling use cases. They are separate stages, working in parallel or dependant, but, to work with smaller images/documents will benefit all. |
…r-patch-2 Delete documentation/API_documentation/README.MD
|
Blocked due lack of status definition: And blocked due JSON ACK definition. If we are talking about confirm status changes or to modify the SDP, an PUT/PATCH sould be the way. It must be valid for all notification channel mechanisms (websocket, PSN or webhook) |
As spoken in the call from 7/may this can be merged (minutes available [here](https://wiki.camaraproject.org/x/MQGCAQ))
cf4c14c to
6eaa474
Compare
flow description of the API BYON.
- The contact information to include domain.com. - In the CallHandling API, the status attribute description is updated.
- Included notes about software behavior - Included details about request/reponses body
- Included versioning - Clear JSON messages about call state - Included comments for review #lightSalmon
62835ba to
286f6a3
Compare
|
- Doc with status enumeration - Uniform API requests and headers - Fixed terminaing flow - Replaced "params" by "headers"
286f6a3 to
13c9e73
Compare
- Confirmed changes after meeting 21/05/24 - Specified vvoipSessionId and racmSessionId - Updated notifications format and responses
|
Ready for merge after review commented today on the meeting. Following #29 session ID variable names. cc.: @deepakjaiswal1 @TEF-RicardoSerr Regards, |
|
@stroncoso-quobis @TEF-RicardoSerr |
|
@stroncoso-quobis Can we also capture call-flow call hold & resume? |
|
Hi @deepakjaiswal1 , reviewed flows after your revision
Check updated UML renders on the PR description. About the 204/200 in response to PUT actions, I suggest to keep the flow as it is to explain the base concept and get more in detail, maybe on the Markdown plain document or in the openApi description. Under that point of view, I consider that a "generic 204" is ok for this flow overview. Regarding the call-flow call hold & resume I agree that it is a great resource to add. I can do it, but I suggest creating a new call flow file on a separate PR and try to touch base with this one. Thanks for your comments! 🙇 |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #18 #32
Special notes for reviewers:
Changelog input
Additional documentation
Included exported UML diagrams for easier review
-- Registration / De-registration--

-- Notification channel --

-- Call handling (Originating / Terminating) --
