Update BYON-CallHandling-Service.yaml#28
Conversation
|
@TEF-RicardoSerr @JavierVillaLabarra I believe it's unnecessary to include {status: 201, code: CREATED} in the responseBody for a 201 created response. |
Updated CallHandlig yaml
I updated the yaml file, you can check it! |
|
@JavierVillaLabarra I think we can omit the ObjectResponse schema. I would update Gereric201 FROM: TO: |
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ReceiverSessionStatus' | ||
| examples: |
There was a problem hiding this comment.
These examples are not relevant here.
There was a problem hiding this comment.
Don't you find it good to have a response type attached in the 201 response? how'd you face this in other way?
There was a problem hiding this comment.
201 Created is to convey to client that the request is accepted, and resource is created on WebRTC Gateway. After 201, the gateway shall initiate the SIP transactions towards the network, based on transactions, subsequent notification shall be sent.
My point was, listing exMT201_183 and exMT201_200 to be removed.
|
@pradeepachar-mavenir @TEF-RicardoSerr @JavierVillaLabarra The PUT response should return a 200 OK status code, with the response body reflecting the updated session object. No new session object is being created, and thus status code 201 Created is not applicable. |
|
Hello @deepakjaiswal1 @pradeepachar-mavenir |
Responding to the #issue24 proposed by @deepakjaiswal1
We have added a 201 type response wich is returning a JSON object regarding the session parameters.
Feel free to add comments
@TEF-RicardoSerr
@pradeepachar-mavenir
@sushanthmavenir