Added Test_definitions folder under code#1
Added Test_definitions folder under code#1MarkusKuemmerle merged 1 commit intocamaraproject:mainfrom
Conversation
Even if the folder structure for Test is not agreed yet: camaraproject#138 camaraproject/Template_API_Repository#1 camaraproject/Commonalities#59 we can anyway discuss about the .feature file for the TI API.
|
@Kevsy considering your proposal for the sub-projects with multiple APIs, then for sub-projects with just one APIs the structure should be: /code/API_defintions/Test_definitions .....also considering the API_definitions folder. Or (option 2) the other way around, for sub-projects with multiple APIs then the structure should be: /code/Test_defintions/{api_sub_group}/.feature or /code/Test_defintions/{api_sub_group}/cucumber I would suggest this second option because if a Developer is used to work in a single API project, he/her expects to find the test folder under /code. |
|
Code only should be in the provider implementation repos, not in the lead repos. The question is if tests are implementation specific or should be implementation independent. I would vote for the last one, then it makes sense to have it as /Test_definitions/ only in the lead repos. |
Correct, although to avoid confusion in this thread, Template Lead repository sets the structure
Yes, I agree |
|
HI @MarkusKuemmerle - I cannot see a CODEOWNER or Maintainers for Template Lead Repository, which means the PR Cannot be merged. Please can you advise? |
|
In a template we can't have maintainers or code owners, because these would be automatially copied then in the Sub Project repos created with the template. The admins can do the merge / changes. You only want to add one additional folder for testing, correct? Shall we add this folder to all exisiting Lead Repos too to be consistent with the template? |
Reference issue #59 in Commonalities
Note: this commit suggests
/code/Test_definitions
...however for sub-projects with multiple APIs then the structure may be:
/code/API_defintions/{api_sub_group}/Test_definitions
e..g. /code/API_definitions/Discovery/Test_definitions