Skip to content

fix: update x-camara-commonalities to 0.6#101

Merged
Kevsy merged 1 commit intomainfrom
Kevsy-patch-7
Jun 6, 2025
Merged

fix: update x-camara-commonalities to 0.6#101
Kevsy merged 1 commit intomainfrom
Kevsy-patch-7

Conversation

@Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Jun 5, 2025

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

updates x-camara-commonalities to 0.6

Which issue(s) this PR fixes:

Fixes #99

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@Kevsy Kevsy self-assigned this Jun 5, 2025
@Kevsy Kevsy added the Fall25 label Jun 5, 2025
@Kevsy Kevsy requested a review from maheshc01 as a code owner June 5, 2025 13:06
@jgarciatovar
Copy link

@Kevsy - I am currently developing changes in AED for Commonalities 0.6, and I've realised that there are couple of things that changed since you merged on SED:

  1. Non-documented errors description - they have updated the paragraph (see Not Documented Error Responses info.description section Commonalities#457)
  2. Remove IDENTIFIER_MISSMATCH - they have also added DeviceResponse object (see Remove IDENTIFIER_MISMATCH error and introduce DeviceResponse object Commonalities#455)

Maybe you can wait for my PR to check the changes and then create a new PR for SED.

@Kevsy
Copy link
Contributor Author

Kevsy commented Jun 6, 2025

HI @jgarciatovar -

#100 is the 'parent' issue of all the sub-issues that make up the Alignment with Commonalties and ICM. The two issues you mention above are already registered as issues and included as sub-issues in that list.

Maybe you can wait for my PR to check the changes and then create a new PR for SED.

My approach is 'one PR per issue' because that keeps the review focused (and usually quicker to resolve). So I'll proceed to merge this one and then work on the rest included in #100.

@Kevsy Kevsy merged commit a0e7acc into main Jun 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: update x-camara-commonalities to 0.6

3 participants