Remove IDENTIFIER_MISMATCH error and introduce DeviceResponse object#455
Merged
rartych merged 9 commits intocamaraproject:mainfrom Jun 3, 2025
Merged
Remove IDENTIFIER_MISMATCH error and introduce DeviceResponse object#455rartych merged 9 commits intocamaraproject:mainfrom
rartych merged 9 commits intocamaraproject:mainfrom
Conversation
PedroDiez
reviewed
May 5, 2025
Contributor
PedroDiez
left a comment
There was a problem hiding this comment.
Fine with the PR proposal
Just some editorial considerations
This was referenced May 13, 2025
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
This was referenced May 21, 2025
This was referenced Jun 5, 2025
This was referenced Jun 30, 2025
rkandoi
added a commit
to rkandoi/DedicatedNetworks
that referenced
this pull request
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
As explained in #431, indicating whether multiple device identifiers match the same device or not can allow the API consumer to correlate different device identifiers with a given device that they may not otherwise know. To prevent this, the API provider must not respond with an error if the identifiers do not match, but instead use only one of the supplied identifiers and indicate which one in the API response.
Which issue(s) this PR fixes:
Fixes #431
Does this PR introduce a breaking change?
Special notes for reviewers:
APIs that accept the
Deviceobject in the request should include an optionalDeviceResponseobject in the response to all the used device identifier to be notified to the API consumer. This is not a breaking change for the API consumer.Changelog input
Additional documentation
None