Skip to content

Submission of test cases#68

Closed
trehman-gsma wants to merge 2 commits intocamaraproject:mainfrom
trehman-gsma:trehman-test-cases
Closed

Submission of test cases#68
trehman-gsma wants to merge 2 commits intocamaraproject:mainfrom
trehman-gsma:trehman-test-cases

Conversation

@trehman-gsma
Copy link
Contributor

@trehman-gsma trehman-gsma commented Oct 31, 2023

What type of PR is this?

Tests

What this PR does / why we need it:

Initial test case proposal. The API readiness checklist states that API test cases should be created.

Created two .feature files that contain Gherkin test cases. One file containing test cases for POST /retrieve-date and the second file containing test cases for POST /check.

The files were created under the /code/Test_definitions as per guidance in camaraproject/Template_API_Repository#1

Which issue(s) this PR fixes:

Fixes #63

Special notes for reviewers:

Initial test case proposal. Will amend as per feedback.

Changelog input

Created /code/Test_definitions/check_simswap.feature containing test cases for POST /check

Created /code/Test_definitions/retrieve_simswap_date.feature containing test cases for POST /retrieve-date

@fernandopradocabrillo
Copy link
Collaborator

fernandopradocabrillo commented Nov 8, 2023

Hi @trehman-gsma!
Thank you for the proposal and starting the discussion regarding the test scenarios.
I've been reviewing it and from Telefónica we have a proposal too that is align with the existing one in Home Devices Qod, which is the only API that has an ATP at the moment. It is a little bit more complete and detailed I believe.

I wasn't sure how to include our proposal so I created a different PR #70

Any feedback is welcome 😄

@fernandopradocabrillo fernandopradocabrillo mentioned this pull request Nov 8, 2023
Merged
@bigludo7
Copy link
Collaborator

bigludo7 commented Nov 20, 2023

Hello @trehman-gsma
Thanks !
I have same comment that for PR#70
What about one additional test for the check when the msisdn obtained from the network in the authorization first step (and passed in the token) is distinct from the one we get in the POST payload ?
We have added 403 for this error.

@bigludo7 bigludo7 mentioned this pull request Nov 30, 2023
Closed
@trehman-gsma
Copy link
Contributor Author

trehman-gsma commented Dec 6, 2023 •
edited
Loading

Hi @fernandopradocabrillo @bigludo7,

Sorry I didn't see this earlier (notifications landed in an unmonitored email folder - my bad).

I'm happy to adopt PR #70 instead of this PR. It covers most of the same test cases - the language differs but that's a syntactic matter to be agreed - and I can see there has been more detailed discussion within #70.

Will provide feedback in PR #70.

Shall I close this PR or wait for camaraproject/Commonalities#94 to close?

@bigludo7
Copy link
Collaborator

bigludo7 commented Dec 7, 2023

@trehman-gsma You should keep it open and waiting for camaraproject/Commonalities#94 outcome. Both your and @fernandopradocabrillo contributions are valuable. We need to agreed on a common pattern and once done we will work from the closest one.

@bigludo7
Copy link
Collaborator

bigludo7 commented Jul 8, 2024

Hi @trehman-gsma
Could you please take a look on what @fernandopradocabrillo proposed it here as it is now aligned with CAMARA test definition guideline.

We can probably close this PR and work only on the PR70 - what do you think?

@trehman-gsma
Copy link
Contributor Author

trehman-gsma commented Jul 8, 2024

Closing this PR in favour of #70 (aligned with CAMARA test definition guidelines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DT-DawidWroblewski DT-DawidWroblewski Awaiting requested review from DT-DawidWroblewski

@bigludo7 bigludo7 Awaiting requested review from bigludo7 bigludo7 is a code owner

@fernandopradocabrillo fernandopradocabrillo Awaiting requested review from fernandopradocabrillo fernandopradocabrillo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Submission of test cases (Gherkin feature files)

3 participants

@trehman-gsma @fernandopradocabrillo @bigludo7