Spring25 - M3 Milestone - Prepare r2.1 by bigludo7 · Pull Request #92 · camaraproject/OTPValidation

bigludo7 · 2025-01-16T20:45:39Z

What type of PR is this?

Add one of the following kinds:

subproject management

What this PR does / why we need it:

This PR implements the scope for Spring25
The PR updates all the file in terms of release number referring to r2.1 and version v1.13.0-rc.1
CHANGELOG.MD, READ.ME & Readiness check list updated version are provided

Which issue(s) this PR fixes:

Fixes camaraproject/Commonalities#91 camaraproject/Commonalities#93

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

github-actions · 2025-01-16T20:46:47Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Errors	Elapsed time
✅ ACTION	actionlint	2	0	0.03s
✅ OPENAPI	spectral	1	0	1.64s
✅ REPOSITORY	git_diff	yes	no	0.01s
✅ REPOSITORY	secretlint	yes	no	0.71s
✅ YAML	yamllint	1	0	0.32s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

CHANGELOG.md

documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md

Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>

…cklist.md Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>

hdamker · 2025-01-23T17:29:29Z

Two comments (I'm currently looking on the stable APIs from Fall24 to see which of them have breaking changes):

optional phoneNumber: either the phoneNumber is required or you need to add the text how the phoneNumber will be determined in case of 3-legged vs 2-legged. But as 3-legged doesn't make sense here, I would go with the conclusion in Update API-design-guidelines.md Commonalities#88 and revert the change. Or have I overseen something?
x-correlator: there will be the change coming with Commonalities 0.5.0-rc.1 with the validation pattern. I would recommend to for the final decision (see Allow zero-length strings in x-correlator header Commonalities#387) on the pattern before creating the release here.

…nement)

code/API_definitions/one-time-password-sms.yaml

Accordingly to https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API-Readiness-Checklist.md

hdamker

@bigludo7:
Several small changes suggested, most of them to correct the version number to 1.1.0-rc.1 (only within the server url v1rc1 is correct).

CHANGELOG.md

hdamker · 2025-02-03T10:48:33Z

CHANGELOG.md

+
+## one-time-password-sms 1.1.0-rc1
+
+This is the first **pre-release** of the one-time-password-sms API version 1.1.0-rc1. It contains mainly alignments with the Commonalities 0.5.0 and the Release Management Guidelines. 


Suggested change

This is the first **pre-release** of the one-time-password-sms API version 1.1.0-rc1. It contains mainly alignments with the Commonalities 0.5.0 and the Release Management Guidelines.

This is the first **pre-release** of the one-time-password-sms API version 1.1.0-rc.1. It contains mainly alignments with the Commonalities 0.5.0 and the Release Management Guidelines.

Just curious: are there relevant changes to the API due to the "Release Management Guidelines". Or did you mean the Identity and Consent Management guidelines?

Hello @hdamker - Yes I mean initially Identity and Consent Management but then as this API is not impacted to the new device/phoneNumber error we are not either impacted by Identity & Consent Management. I've removed mention to Identity and Consent Management & Release management to only keep Commonalities.

CHANGELOG.md

documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Remove release management in line 29

Update release version in line 29

bigludo7 · 2025-02-03T13:19:37Z

Hello @hdamker
Thanks a lot for the review
All applied.

hdamker

Looks good from Release Management perspective.

@bigludo7 There is one question open, which you haven't resolved for some reason.

hdamker

I was a little bit too fast ... just have found one open point which should be corrected.

hdamker · 2025-02-03T21:28:12Z

code/API_definitions/one-time-password-sms.yaml

Just have found one of my comments which are not yet done: The text in lines 18 to 20 need to be updated with the latest changes in ICM r2.2

Done - I've copied the text.

Updated Authorization and authentication part in the yaml

hdamker · 2025-02-04T14:46:46Z

I will unblock the PR after the version issue within camaraproject/NumberVerification#164 (comment) is discussed and solved in Release Management, as the same applies also here for OTPValidation.

bigludo7 · 2025-02-10T15:47:07Z

I will unblock the PR after the version issue within camaraproject/NumberVerification#164 (comment) is discussed and solved in Release Management, as the same applies also here for OTPValidation.

@hdamker I've applied camaraproject/ReleaseManagement#163

Change version in the path from v1 to v1.1.0-rc.1

hdamker

LGTM - thanks for your patience and quick responses!

bigludo7 · 2025-02-11T10:23:34Z

LGTM - thanks for your patience and quick responses!

Thanks for your review & guidance Herbert !

bigludo7 added 4 commits January 16, 2025 21:27

Add files via upload

be2beb1

Add files via upload

5d1ddf2

Set the version

9b9f674

Update the version

e48d0e4

bigludo7 requested a review from a team January 16, 2025 20:45

bigludo7 requested a review from fernandopradocabrillo as a code owner January 16, 2025 20:45

fernandopradocabrillo reviewed Jan 17, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

hdamker mentioned this pull request Jan 17, 2025

OTPValidation r2.1 (Spring25 M3) release review camaraproject/ReleaseManagement#141

Closed

11 tasks

fernandopradocabrillo reviewed Jan 17, 2025

View reviewed changes

documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md Outdated Show resolved Hide resolved

bigludo7 and others added 2 commits January 20, 2025 11:23

Update CHANGELOG.md

53b5a16

Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

508b68e

…cklist.md Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>

fernandopradocabrillo previously approved these changes Jan 21, 2025

View reviewed changes

switch phoneNumber back to mandatory

de04a02

bigludo7 dismissed fernandopradocabrillo’s stale review via de04a02 January 23, 2025 20:36

bigludo7 added 2 commits January 23, 2025 21:38

Define pattern & example for x-correlator

25eb23e

Update CHANGELOG.md (phoneNumber back to mandatory & x-correlator aig…

04ede65

…nement)

hdamker reviewed Jan 24, 2025

View reviewed changes

code/API_definitions/one-time-password-sms.yaml Outdated Show resolved Hide resolved

bigludo7 added 3 commits January 28, 2025 10:11

Add pattern for x-correlator & update 429 message

8397f1f

Add pattern for x-correlator & update 429 message

6bd412b

Update OTPvalidationAPI-Readiness-Checklist.md

de5985b

Accordingly to https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API-Readiness-Checklist.md

hdamker requested changes Feb 3, 2025

View reviewed changes

bigludo7 and others added 7 commits February 3, 2025 14:01

Update CHANGELOG.md

bcbc7de

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

18d41d9

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

c181dfb

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

8a5df9d

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

2b9feab

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

799e097

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

44219a9

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

bigludo7 and others added 11 commits February 3, 2025 14:04

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

2d9ee84

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

51d818a

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

7d56178

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

552cfda

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update README.md

d7bd4a2

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update code/API_definitions/one-time-password-sms.yaml

5319253

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update code/Test_Definitions/one-time-password-sms.feature

598db76

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/OTPvalidationAPI-Readiness-Che…

5aaadbc

…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update README.md

3dd3a09

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

d3faa9d

Remove release management in line 29

Update CHANGELOG.md

41f3647

Update release version in line 29

hdamker approved these changes Feb 3, 2025

View reviewed changes

hdamker requested changes Feb 3, 2025

View reviewed changes

bigludo7 added 2 commits February 4, 2025 08:41

Update OTPvalidationAPI-Readiness-Checklist.md

5cc0258

Update Authorization and authentication documentation

6dd5a20

Updated Authorization and authentication part in the yaml

Change in the url the version to v1.1.0-rc.1

038f20b

hdamker previously approved these changes Feb 10, 2025

View reviewed changes

Update one-time-password-sms.feature

a7cd868

Change version in the path from v1 to v1.1.0-rc.1

bigludo7 dismissed hdamker’s stale review via a7cd868 February 11, 2025 07:58

fernandopradocabrillo approved these changes Feb 11, 2025

View reviewed changes

hdamker approved these changes Feb 11, 2025

View reviewed changes

bigludo7 merged commit 95c91ad into main Feb 11, 2025
2 checks passed

bigludo7 deleted the Prepare-r2.1 branch February 11, 2025 10:23


		## one-time-password-sms 1.1.0-rc1

		This is the first pre-release of the one-time-password-sms API version 1.1.0-rc1. It contains mainly alignments with the Commonalities 0.5.0 and the Release Management Guidelines.

Conversation

bigludo7 commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Additional documentation

Uh oh!

github-actions bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

Uh oh!

Uh oh!

hdamker commented Jan 23, 2025

Uh oh!

Uh oh!

hdamker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hdamker Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

bigludo7 Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigludo7 commented Feb 3, 2025

Uh oh!

hdamker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

hdamker Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

bigludo7 Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

hdamker commented Feb 4, 2025

Uh oh!

bigludo7 commented Feb 10, 2025

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

bigludo7 commented Feb 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bigludo7 commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

hdamker left a comment •

edited

Loading

hdamker left a comment •

edited

Loading