Merged
Conversation
Collaborator
|
It might be easier to use the CAMARA wiki for meeting minutes in future rather than continue to use github |
patrice-conil
approved these changes
Dec 6, 2023
| | Issue<br> [#77](https://github.com/camaraproject/Commonalities/issues/77) | **Response Headers** <br> Eric will rise the PR clarifying use of non-standard headers like X-Correlator. There are different views on presence of header definitions in CAMARA YAML files. More comment expected.| | ||
| | Issue<br> [#71](https://github.com/camaraproject/Commonalities/issues/71) | **basePath in servers.url** <br> This issue should be covered within Release Management activity. | | ||
| | Issue<br> [#67](https://github.com/camaraproject/Commonalities/issues/67) | **Open points for release management** <br> Presentation prepared by Herbert and Ludovic for TSC discussion is available in [Governance repository](https://github.com/camaraproject/Governance/raw/b62e6214f06f8a88a5870d00584fbf8126f3cd58/documentation/MeetingMinutes/TSC/TSC-2023-10-19-Release-Management.pptx.pptx). All interested in participating in this activity should subscribe to [mailing list](https://lists.camaraproject.org/g/release). Linux Foundation will provide training on Release Management best practices. | | ||
| | PR [#43](https://github.com/camaraproject/Commonalities/pull/43) | **Event Notification using CloudEvents specification**<br> Review needed after introduced changes. We should have `application/cloudevents+json` instead of `application/json` as content type for event notifications. This point requires updating the example in the DG and probably adding a note. Rajat highlighted that `cloudevents+json` is not part of IANA registration but agreed that we can move forward. | |
Contributor
There was a problem hiding this comment.
Hi @rartych,
content-type is already set to application/cloudevents+json
but in the example the datacontenttype which is type of data should remain application/json
Do you agree with that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
MoM-30-10-2023