Conversation
BTW: you could have just reopened the PR, but it's also fine so. Please complete the release PR, until then I have converted it to "draft", as it is not yet ready for review. Use the "Ready for review" button when all needed changes are included. |
README.md
Outdated
| # ModelAsAService | ||
| API Repository to describe, develop, document, and test the service APIs of the [ModelAsAService](https://lf-camaraproject.atlassian.net/wiki/x/AgDe) family | ||
| !! Replace the link with the link to the home page within the wiki and delete this task | ||
| API Repository to describe, develop, document, and test the service APIs of the [ModelAsAService](https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/52658427/ModelAsAService) family |
There was a problem hiding this comment.
Please rebase your PR with current main branch, and keep the first 14 line which are currently in main branch unchanged (the link there is already correct, and we use the shorter "share" links),
There was a problem hiding this comment.
Thanks for the feedback!
We've rebased the PR onto the latest main branch and confirmed the first 14 lines remain unchanged (including the correct short "share" link).
Regarding the README:
We've updated the meeting schedule and links in this PR. Could these changes be incorporated?
There was a problem hiding this comment.
Regarding the README:
We've updated the meeting schedule and links in this PR. Could these changes be incorporated?
Sure you can ... but in this case you need to resolve a merge conflict as there was also a change within the main branch.
Keep the first 14 line which are currently in main branch unchanged. Update the meeting link.
Update link to Commonalities and ICM r3.2
Update link to Commonalities and ICM r3.2
Update link to Commonalities and ICM r3.2
|
We have gone through the Review actions list for ModelAsAService r1.1 (Fall25 M3, new APIs) release review item by item, checked and modified the relevant files as required. |
|
Thanks @lihaojie-CMCC : API User Story is optional, but please change the API Readiness Checklist to say 'N' (I think it says 'tbc' at the moment) Yes the bot review is complete 😁 , but there is also my manual review. I have included knowledge-base.yaml and qa-assistant-manage.yaml below in this comment, and I will complete the other files later knowledge-base.yaml
qa-assistant-manage.yaml
So e.g. for the
|
|
A few more manual review comments: qa-assistant-service.yaml
|
|
@lihaojie-CMCC Please note I have updated the comment above with the correct scope syntax to apply in knowledge-base.yaml: "2. The scope |
|
@Kevsy Thanks again for your thorough review! We've implemented all the suggested changes:
We've also verified and updated the Test definitions to reflect these modifications. Your expertise really elevated the quality of this implementation – much appreciated! |
|
Thanks @lihaojie-CMCC - nearly there, just a few suggestions added above 👍 |
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
| servers: | ||
| - url: '{apiRoot}/qa-assistant-manage/vwip' | ||
| servers: | ||
| - url: {apiRoot}/qa-assistant-manage/v0.1rc1 |
There was a problem hiding this comment.
| - url: {apiRoot}/qa-assistant-manage/v0.1rc1 | |
| - url: {apiRoot}/qa-assistant-manage/v0.1rc1 |
There was a problem hiding this comment.
Sorry @lihaojie-CMCC I made a whitespace mistake in my initial suggestion - the suggestion above should fix it :)
There was a problem hiding this comment.
No worries at all, @Kevsy – happens to the best of us! 😄 I originally thought it was another issue, but the whitespace fix is now sorted. Thanks for catching that!
Kevsy
left a comment
There was a problem hiding this comment.
Release PR Approved on behalf of Release Management
Next steps for the ModelAsAService codeowners:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)*
- Release Tracker updated (with creation date of the release and the release tag link)
*Note please follow these instructions to make the pre-release
|
HI @lihaojie-CMCC , please see the required actions above: they are required to achieve M3 for Fall 25. They must be done by the repository codeowners (release management are not able to do them). Thanks! |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Prepare the release r1.1:
Which issue(s) this PR fixes:
Fixes #12
Special notes for reviewers:
NOTE: PR #13 was accidentally closed. This PR serves as a follow-up to that work. For full context on previous progress/discussions, please refer to the history in #13 .