Skip to content

Release r1.1 with 0.1.0-rc.1#13

Closed
lihaojie-CMCC wants to merge 5 commits intomainfrom
lihaojie-CMCC-patch-1
Closed

Release r1.1 with 0.1.0-rc.1#13
lihaojie-CMCC wants to merge 5 commits intomainfrom
lihaojie-CMCC-patch-1

Conversation

@lihaojie-CMCC
Copy link
Contributor

@lihaojie-CMCC lihaojie-CMCC commented Jun 27, 2025

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Prepare the release r1.1:

Update CHANGELOG.md
Add API readiness checklist
Update API yaml files

Which issue(s) this PR fixes:

Fixes #12

Special notes for reviewers:

@hdamker
Copy link
Contributor

hdamker commented Jun 27, 2025

BTW: please check the test definition .feature files against https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Testing-Guidelines.md ... aligning them might be worth a separate PR.

I just recognized it, as in the first line of each file you will then set as well the version here in the release PR.

@hdamker
Copy link
Contributor

hdamker commented Jun 27, 2025

Beyond that I suppose that this PR is currently a draft (you might consider to "convert to draft"). As soon as it is complete (especially the CHANGELOG.md is added) the @camaraproject/release-management_reviewers team will be added automatically as reviewer.

@lihaojie-CMCC lihaojie-CMCC marked this pull request as draft June 27, 2025 08:59
@lihaojie-CMCC lihaojie-CMCC added subproject management Issues and PRs related to the management of the sub project Fall25 labels Jun 27, 2025
@lihaojie-CMCC lihaojie-CMCC marked this pull request as ready for review June 27, 2025 09:15
@lihaojie-CMCC lihaojie-CMCC marked this pull request as draft June 27, 2025 09:16
@lihaojie-CMCC
Copy link
Contributor Author

Beyond that I suppose that this PR is currently a draft (you might consider to "convert to draft"). As soon as it is complete (especially the CHANGELOG.md is added) the @camaraproject/release-management_reviewers team will be added automatically as reviewer.

Thank you for the reminder! We completely missed that step and appreciate you pointing it out.

We've now added the CHANGELOG.md file and marked this PR as ready for review as you suggested. However, it seems the @camaraproject/release-management_reviewers team hasn't been automatically added yet.

Is there a way we can manually add them as reviewers at this stage? Thanks for your guidance!

@lihaojie-CMCC lihaojie-CMCC marked this pull request as ready for review June 27, 2025 09:24
@lihaojie-CMCC lihaojie-CMCC requested a review from a team June 27, 2025 09:29
@lihaojie-CMCC
Copy link
Contributor Author

We have now manually added the release-management reviewers team as reviewers.

@hdamker
Copy link
Contributor

hdamker commented Jun 27, 2025

We've now added the CHANGELOG.md file and marked this PR as ready for review as you suggested. However, it seems the @camaraproject/release-management_reviewers team hasn't been automatically added yet.

Reason is that you named the file CHANGELOG, not CHANGELOG.md (see the rule in CODEOWNERS). And please delete the release tag https://github.com/camaraproject/ModelAsAService/releases/tag/r1.1 which you have already created. It is lacking all the content from e.g. this PR here.

@lihaojie-CMCC
Copy link
Contributor Author

We've now added the CHANGELOG.md file and marked this PR as ready for review as you suggested. However, it seems the @camaraproject/release-management_reviewers team hasn't been automatically added yet.

Reason is that you named the file CHANGELOG, not CHANGELOG.md (see the rule in CODEOWNERS). And please delete the release tag https://github.com/camaraproject/ModelAsAService/releases/tag/r1.1 which you have already created. It is lacking all the content from e.g. this PR here.

Got it, thanks for pointing it out!

And about the tag, my sincere apologies for the misstep—I intended to create a draft release rather than a public one. Thank you for catching this and for the clear reminder about the correct workflow (post-PR completion, review, approval, and merge). I’ll make sure to follow the proper steps moving forward.

@lihaojie-CMCC
Copy link
Contributor Author

For the related changes to the API Test definitions, please see PR #14.

@hdamker
Copy link
Contributor

hdamker commented Jun 29, 2025

I intended to create a draft release rather than a public one

No worries, that can happen. I've deleted the tag (as you will need the name later to point to the merge commit of this PR here).

For the related changes to the API Test definitions, please see PR #14.

Yes, makes sense. PR #14 need then to be merged to get the release PR ready for final review.

I will create the release review issue in Release Management already, but will consider it as draft until the versions within the API definition file are set here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fall25 subproject management Issues and PRs related to the management of the sub project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release PR for Fall25 M3 milestone

2 participants