Conversation
|
BTW: please check the test definition .feature files against https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Testing-Guidelines.md ... aligning them might be worth a separate PR. I just recognized it, as in the first line of each file you will then set as well the version here in the release PR. |
|
Beyond that I suppose that this PR is currently a draft (you might consider to "convert to draft"). As soon as it is complete (especially the CHANGELOG.md is added) the @camaraproject/release-management_reviewers team will be added automatically as reviewer. |
Thank you for the reminder! We completely missed that step and appreciate you pointing it out. We've now added the CHANGELOG.md file and marked this PR as ready for review as you suggested. However, it seems the @camaraproject/release-management_reviewers team hasn't been automatically added yet. Is there a way we can manually add them as reviewers at this stage? Thanks for your guidance! |
|
We have now manually added the release-management reviewers team as reviewers. |
Reason is that you named the file CHANGELOG, not CHANGELOG.md (see the rule in CODEOWNERS). And please delete the release tag https://github.com/camaraproject/ModelAsAService/releases/tag/r1.1 which you have already created. It is lacking all the content from e.g. this PR here. |
Got it, thanks for pointing it out! And about the tag, my sincere apologies for the misstep—I intended to create a draft release rather than a public one. Thank you for catching this and for the clear reminder about the correct workflow (post-PR completion, review, approval, and merge). I’ll make sure to follow the proper steps moving forward. |
|
For the related changes to the API Test definitions, please see PR #14. |
No worries, that can happen. I've deleted the tag (as you will need the name later to point to the merge commit of this PR here).
Yes, makes sense. PR #14 need then to be merged to get the release PR ready for final review. I will create the release review issue in Release Management already, but will consider it as draft until the versions within the API definition file are set here. |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Prepare the release r1.1:
Update CHANGELOG.md
Add API readiness checklist
Update API yaml files
Which issue(s) this PR fixes:
Fixes #12
Special notes for reviewers: