Add basic testcases for the new APIs conncted-network-type and connected-network-type-subscriptions#251
Merged
akoshunyadi merged 33 commits intocamaraproject:mainfrom Feb 10, 2025
Merged
Conversation
bigludo7
reviewed
Jan 28, 2025
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
I've one comment common to all 3 subscriptions for SUBSCRIPTION_MISMATCH UC.
This is not related to the device token but to the event type "consented" vs requested.
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
bigludo7
reviewed
Jan 29, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
bigludo7
previously approved these changes
Jan 31, 2025
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Look good for me.
Thanks @dfischer-tech
Note that it could be unsupported or unauthorized. Indeed for me the error is triggered as long as the event type(s) linked to the token are not aligned with event type in the request. But I'm fine with your proposal.
akoshunyadi
reviewed
Feb 5, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
maxl2287
approved these changes
Feb 7, 2025
Contributor
There was a problem hiding this comment.
LGTM
@bigludo7 @akoshunyadi @eric-murray can we get this approved / merged asap so that we can progress on the Pre-Release PR?
akoshunyadi
previously approved these changes
Feb 7, 2025
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
eric-murray
reviewed
Feb 7, 2025
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
…ture Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…ture Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…ture Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…ture Co-authored-by: Eric Murray <eric.murray@vodafone.com>
…ture Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
….feature Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
….feature Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Contributor
Author
A few remarks from my side:
|
akoshunyadi
approved these changes
Feb 10, 2025
eric-murray
approved these changes
Feb 10, 2025
Collaborator
eric-murray
left a comment
There was a problem hiding this comment.
OK. Let's merge this one as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
In order to participate in the next meta release, we need basic test cases for the new APIs.
Fixed typos and format issues in the existing ones.
Which issue(s) this PR fixes:
Fixes #234