@sachinvodafone thanks for your effort! I'm going to review it this evening....

@sachinvodafone thanks for your effort! I'm going to review it this evening....

I am finding one error in Linter and trying to fix it

Hello @akoshunyadi @sachinvodafone I'm not sure we have a global decision on this topic. For me we have to keep the device in the event specialization provided in the yaml as we have no indication here: https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#event-notification-definition I note that in the guideline the subscriptionId is optional so it makes sense to keep the device identifier else it will be impossible to correlate the event to a device.

We should keep device, but as an optional parameter for both EventNetworkTypeChangeData and EventSubscriptionEnds. Currently it is required. If the subscription is created using an explicit device identifier, then it is OK to include it in the event notifications. Otherwise, it should not be included.

At some point we might consider returning the sub parameter of the ID token here when subscriptions are created using a 3-legged token, as the API consumer already knows the sub when the got their access token. But that is for a later version.

Marked it as optional.