Update device-status.yaml#111
Merged
akoshunyadi merged 2 commits intocamaraproject:mainfrom Mar 13, 2024
Merged
Conversation
Updating paths to align with Design Guidelines.
bigludo7
previously approved these changes
Feb 14, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
LGTM - Time to make the change.
Collaborator
|
In the header, lines 54 and 58, there are still the old endpoints. |
Replacing header lines based on new proposed endpoints
akoshunyadi
approved these changes
Mar 4, 2024
sachinvodafone
approved these changes
Mar 13, 2024
Collaborator
|
@gmuratk Sorry, during our Camara call I accidentally merged your PR, it should be only merged little later, after we branched for the 0.5.1. I reverted it, but now the PR is missing. Could you please recreate the PR? Thanks! |
gmuratk
added a commit
to gmuratk/DeviceStatus-fix-path
that referenced
this pull request
Mar 20, 2024
Re-submission of the PR (camaraproject#111)
This was referenced Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating paths to align with Design Guidelines.
What type of PR is this?
What this PR does / why we need it:
To comply with CAMARA API Design Guidelines.
Which issue(s) this PR fixes:
Fixes #96
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.