fix: add missing "subscriptionId" in "RoamingStatus"-data for CloudEvent#109
Conversation
|
Hi @maxl2287 , It appears that this pull request aims to address two issues. First, correcting the device object where the country code was incorrectly placed under the device object. Second, ensuring that the country name is represented as an array, not a string, in the callback event . As per my understanding, It does not involve adding or amending the subscription field, as indicated in the request description, am i correct ? |
7d1fb23 to
dae24e8
Compare
dae24e8 to
c12b840
Compare
|
@sachinvodafone you're right! Thanks for the hint! |
|
Just one comment here. Shouldn't this be a fix? instead of going in the v0.6.0-wip, couldn't we include it in a v0.5.1? |
any thoughts? Once a team starts to implement the 0.5.0 version it's going to be obvious that there is a bug and I don't think that waiting to release a 0.6.0 is the best option. wdyt? |
I aggree. @bigludo7 @akoshunyadi what about 0.5.1-wip ? |
|
The general idea in Camara is to make more -smaller- releases, so 0.6.0 should come quite soon, I would say. But I don't have any objection, if somebody needs a 0.5.1 even sooner. |
|
I'll create an issue for 0.5.1, where we can discuss and define the content of it. |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
In the examples of callback CloudEvents for roaming-status, there is the subscriptionId given, but not in the corresponding component.
This will be fixed with this PR.