Skip to content

fix: move "countryCode" out of "device" in ROAMING_CHANGE_COUNTRY-example#106

Merged
akoshunyadi merged 2 commits intocamaraproject:mainfrom
maxl2287:fix/correct-example-country-code
Feb 9, 2024
Merged

fix: move "countryCode" out of "device" in ROAMING_CHANGE_COUNTRY-example#106
akoshunyadi merged 2 commits intocamaraproject:mainfrom
maxl2287:fix/correct-example-country-code

Conversation

@maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Feb 7, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Moves the "countryCode" parameter out of the "device"-parameter.
Adds "countryName" inside of the corresponding example.

@maxl2287 maxl2287 changed the title fix: fix: move "countryCode" out of "device" in ROAMING_CHANGE_COUNTRY-example fix: move "countryCode" out of "device" in ROAMING_CHANGE_COUNTRY-example Feb 7, 2024
bigludo7
bigludo7 previously approved these changes Feb 7, 2024
eric-murray
eric-murray previously approved these changes Feb 7, 2024
@akoshunyadi
Copy link
Collaborator

This is the first PR after the release, so we should change the version number to 0.6.0-wip.

@maxl2287 maxl2287 dismissed stale reviews from eric-murray and bigludo7 via d782410 February 7, 2024 14:17
@akoshunyadi akoshunyadi merged commit fc052bb into camaraproject:main Feb 9, 2024
@akoshunyadi akoshunyadi mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants