YAML Update: add UNKNOWN for verify location#22
Merged
jlurien merged 17 commits intocamaraproject:dev-0.2.0from Feb 20, 2023
Merged
YAML Update: add UNKNOWN for verify location#22jlurien merged 17 commits intocamaraproject:dev-0.2.0from
jlurien merged 17 commits intocamaraproject:dev-0.2.0from
Conversation
…kar-patch-1 Update CODEOWNERS
Added 404 error
…ion-api-doc Create Location_API.md
…README-meeting-details Update README.md
Draft agenda for WG meeting
…23-01-31 Draft MoM 2023-01-31
Adding "unknown" camaraproject#19 It can happen that the network can't locate the device, because it is offline and the location is also not cached. In this there should be coming the right response from the API. Changes Adding to true or false the return value unkown, when it is not possible to get the location
…ation YAML Update: add unkown for verify location
Changing Enum value into capital letters.
Removing nested block
bigludo7
reviewed
Feb 7, 2023
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Hello
Thanks for this. For me adding unknown value is a good. 2 comments:
- We should use same case in the swagger: true, false, UNKNOWN (upper case or minor case but same)
- Documentation (.md) should be updated (line) 48 to list the 3 values;
Thanks
Added review comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding "unknown" #19
It can happen that the network can't locate the device, because it is offline and the location is also not cached. In this there should be coming the right response from the API.
Changes
Adding to true or false the return value unkown, when it is not possible to get the location