Conversation
bigludo7
left a comment
There was a problem hiding this comment.
Look almost good.
Only one point: the swagger features a 404 that you did not documented.
BTW I'm not sure about 404 usage - for a request to a subscription which is not managed by the network provider?
Yes, I missed it according to the yaml. Really I think 404 makes no sense for this endpoint as there are no path parameters which could point to a not found resource. All error stuff is just copied and pasted from other APIs, so was not well thought. Anyway, for this V0.1 I will align doc with yaml and let's work on better errors in future versions. |
Added 404 error
The agreed version of this API missed the API doc md that we have for other APIs. I followed the usual template.