Fixed issue where containerapp up would not honor --registry-server.#128
Merged
runefa merged 3 commits intocalvinsID:containerapp-0.3.7from Jun 13, 2022
Merged
Fixed issue where containerapp up would not honor --registry-server.#128runefa merged 3 commits intocalvinsID:containerapp-0.3.7from
runefa merged 3 commits intocalvinsID:containerapp-0.3.7from
Conversation
Collaborator
Author
StrawnSC
approved these changes
Jun 10, 2022
Collaborator
|
LGTM, but we should add an entry in the history file and check that the style is good |
runefa
added a commit
that referenced
this pull request
Jul 15, 2022
* init containerapp version 0.3.7 * Use PATCH API for containerapp update. * Removed double lines. * fix bug * Fix microsoft/azure-container-apps#261 * Fixed issue where containerapp up would not honor --registry-server. (#128) * Fixed issue where containerapp up would not honor --registry-server. * Updated history. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * bug fix * add tests * fix credscan suppressions * Use constant for acr registry prefix. * Fixed multi-container issue. * Removed comment. * Updated update_containerapp_yaml to use patch. Fixed minor style errors. * Fixed merge conflicts. * Rerecorded necessary tests. * Updated history. * Auto-populate secret values if passed without values. * Fixed bug where the containerapp had no secrets. Co-authored-by: Silas Strawn <strawnsc@gmail.com> Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.