fix: push '\' into className before regex special characters #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `extractClassesFromHtml` function can fail to parse the some HTMLs because they have class names including special characters for regular expression.
|
Hey @SeokminHong, thank you for your pull request 🤗. |
|
Just stumbled upon the same error! Would love to see this merged. How can I help? |
Anber
approved these changes
Sep 3, 2020
Anber
pushed a commit
that referenced
this pull request
Sep 3, 2020
* fix: push '\' into className before regex special characters * The `extractClassesFromHtml` function can fail to parse the some HTMLs because they have class names including special characters for regular expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I use a HTML elements containing regex's special characters(
\,$, and so on) for class,extractClassesFromHtmlfunction fails to parse them.Summary
extractClassesFromHtmlreturns a regex array for matching class, thus I added escape characters(\) before the special characters.Test plan
Try to parse the HTML document having class containing following characters for its class:
\,^,$,{,},[,],(,),.,*,+,?,|For example:
<code class="language-C++">