Add GITHUB_TOKEN default value in action.yml#341
Add GITHUB_TOKEN default value in action.yml#341benschwarz merged 1 commit intocalibreapp:mainfrom kdeldycke:patch-2
GITHUB_TOKEN default value in action.yml#341Conversation
Added GITHUB_TOKEN input for pull request operations.
|
|
GITHUB_TOKEN default value in action.yml
|
Nice @kdeldycke 🙇♂️ Once you've signed the CLA and tests pass, I'll get it straight onto |
benschwarz
left a comment
There was a problem hiding this comment.
Nice. I didn't realise we could set the default like this.
|
CLA signed! :) |
Not my first time: AndreasAugustin/actions-template-sync#483 ! 😉 |
|
And thanks for the merge! :) |
|
Nice! Does this default value mean that the |
Yes! That's the point! :) |
|
@kdeldycke great, so another PR should be opened to update the readme too? Right now, there are a lot of |
|
@kdeldycke @benschwarz should I open a PR to remove all readme docs for |
After calibreapp#341 the `GITHUB_TOKEN` input parameter isn't needed unless customizing the token
|
I opened one here: |
What does this PR introduce?
Add default value for the
GITHUB_TOKENfield.Related issues
That's just a quality of life improvement, so we don't need to specify it by default.