[CAL-1095] Embed modal (floating pop up button) - UI/layout/spacing issues#8217
[CAL-1095] Embed modal (floating pop up button) - UI/layout/spacing issues#8217keithwillcode merged 9 commits intomainfrom
Conversation
CAL-1095 Embed modal (floating pop up button) - UI/layout/spacing issues
Currently CleanShot 2023-02-16 at 19.21.112x.png Should be CleanShot 2023-02-16 at 19.26.302x.png Note: No need to touch the preview - just the modal and left panel UI. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 112 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/02/2023 06:48:22pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 7da271f Started: 05/02/2023 06:38:11pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1 • Initial Attempt |
3.21% (6)6 / 187 runsfailed over last 7 days |
21.39% (40)40 / 187 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- new-booker Can cancel the recently created booking and rebook the same timeslot
Retry 1 • Initial Attempt |
1.04% (2)2 / 193 runsfailed over last 7 days |
2.59% (5)5 / 193 runsflaked over last 7 days |
📄 apps/web/playwright/app-store.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
App Store - Authed Browse apple-calendar and try to install
Retry 1 • Initial Attempt |
0.99% (2)2 / 202 runsfailed over last 7 days |
42.57% (86)86 / 202 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
12.69% (17)17 / 134 runsfailed over last 7 days |
44.03% (59)59 / 134 runsflaked over last 7 days |
9639e0a to
337ab32
Compare
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
CarinaWolli
left a comment
There was a problem hiding this comment.
Tablet view is broken, let's just put button color and text color under each other when the screen is getting too small:
Everything else looks good to me 🙏
|
we should also extract all strings into en/common.json |
|
Too much spacing above Theme Selector in Inline and Element Click |
hariombalhara
left a comment
There was a problem hiding this comment.
Left a comment. Apart from that it's good.
|
@CarinaWolli I guess it just needs your review to be merged. |
…ssues (calcom#8217) * [CAL-1095] Embed modal (floating pop up button) - UI/layout/spacing issues * requested changes --------- Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Fixes #7156
Demo
https://www.loom.com/share/6f52f4e1fab640e39dd0ec5717ace0d0