Skip to content

HotFix: Broken Email Field in Routing Form#8074

Merged
kodiakhq[bot] merged 2 commits intomainfrom
fix/email-field
Apr 4, 2023
Merged

HotFix: Broken Email Field in Routing Form#8074
kodiakhq[bot] merged 2 commits intomainfrom
fix/email-field

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Apr 4, 2023

Fixes #8075

Make Email field full width and add dark mode styles and make it fully consistent visually with TextWidget
Also, the Form Submission stopped working with Email field.

Before:
Screenshot 2023-04-04 at 12 48 49 PM
Screenshot 2023-04-04 at 12 49 25 PM
Screenshot 2023-04-04 at 1 06 37 PM

After:
Screenshot 2023-04-04 at 12 46 41 PM
Screenshot 2023-04-04 at 12 48 26 PM

Regression from #8047

@hariombalhara hariombalhara requested a review from a team April 4, 2023 07:14
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ❌ Failed (Inspect) Apr 4, 2023 7:30am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2023 7:30am
ui ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2023 7:30am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 183.33 KB 416.7 KB 119.06% (🟡 +0.12%)
/apps/[slug]/[...pages] 390.94 KB 624.31 KB 178.37% (🟡 +0.02%)
/apps/installed/[category] 195.45 KB 428.82 KB 122.52% (🟢 -0.04%)
/auth/setup 79.83 KB 313.2 KB 89.49% (🟢 -0.19%)
/d/[link]/book 182.99 KB 416.35 KB 118.96% (🟡 +0.13%)
/event-types 348.15 KB 581.52 KB 166.15% (🟡 +0.04%)
/event-types/[type] 381.35 KB 614.72 KB 175.63% (🟢 -0.12%)
/getting-started/[[...step]] 304.13 KB 537.5 KB 153.57% (🟡 +0.04%)
/settings/admin/apps 164.14 KB 397.5 KB 113.57% (🟢 -0.10%)
/settings/admin/apps/[category] 164.12 KB 397.49 KB 113.57% (🟢 -0.10%)
/settings/my-account/conferencing 159.07 KB 392.44 KB 112.13% (🟢 -0.04%)
/settings/my-account/profile 271.13 KB 504.49 KB 144.14% (🟡 +0.04%)
/settings/teams/[id]/profile 265.77 KB 499.14 KB 142.61% (🟡 +0.04%)
/team/[slug]/book 182.99 KB 416.36 KB 118.96% (🟡 +0.13%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@hariombalhara hariombalhara changed the title Fix: Email Field in Routing Form Fix: Broken Email Field in Routing Form Apr 4, 2023
@hariombalhara
Copy link
Copy Markdown
Member Author

If there would have been a test for Email field, we could have avoided this issue.

@hariombalhara hariombalhara self-assigned this Apr 4, 2023
@hariombalhara hariombalhara changed the title Fix: Broken Email Field in Routing Form HotFix: Broken Email Field in Routing Form Apr 4, 2023
@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Apr 4, 2023

Current Playwright Test Results Summary

✅ 60 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/04/2023 07:55:13am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d570b98

Started: 04/04/2023 07:49:09am UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
4.23% (8) 8 / 189 runs
failed over last 7 days
22.75% (43) 43 / 189 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
8.72% (13) 13 / 149 runs
failed over last 7 days
26.85% (40) 40 / 149 runs
flaked over last 7 days

View Detailed Build Results


@kodiakhq kodiakhq bot merged commit 73bfe0a into main Apr 4, 2023
@kodiakhq kodiakhq bot deleted the fix/email-field branch April 4, 2023 07:55
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1402] Email Field in Routing Form is Broken

3 participants