Skip to content

refactor: replace TextWidget component with EmailField#8047

Merged
PeerRich merged 4 commits intocalcom:mainfrom
saideepesh000:replace-textwidget
Apr 2, 2023
Merged

refactor: replace TextWidget component with EmailField#8047
PeerRich merged 4 commits intocalcom:mainfrom
saideepesh000:replace-textwidget

Conversation

@saideepesh000
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #7477

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@saideepesh000 saideepesh000 requested a review from a team April 1, 2023 17:41
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal 🔄 Building (Inspect) Apr 2, 2023 4:33pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 4:33pm

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2023

@saideepesh000 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.33 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.45 KB 241.77 KB 69.08% (+/- <0.01%)
/[user] 70.21 KB 303.53 KB 86.72% (+/- <0.01%)
/[user]/[type] 91.95 KB 325.27 KB 92.93% (+/- <0.01%)
/[user]/[type]/embed 91.97 KB 325.3 KB 92.94% (+/- <0.01%)
/[user]/embed 70.27 KB 303.6 KB 86.74% (+/- <0.01%)
/apps 167.25 KB 400.57 KB 114.45% (+/- <0.01%)
/apps/[slug] 190.97 KB 424.29 KB 121.23% (+/- <0.01%)
/apps/[slug]/[...pages] 392.37 KB 625.7 KB 178.77% (+/- <0.01%)
/apps/categories 152.14 KB 385.47 KB 110.13% (+/- <0.01%)
/apps/categories/[category] 156.01 KB 389.34 KB 111.24% (+/- <0.01%)
/apps/installed/[category] 197 KB 430.32 KB 122.95% (+/- <0.01%)
/auth/error 19.24 KB 252.57 KB 72.16% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.96 KB 73.99% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.16 KB 76.04% (🟡 +0.01%)
/auth/login 40.1 KB 273.43 KB 78.12% (+/- <0.01%)
/auth/logout 7.56 KB 240.89 KB 68.82% (🟡 +0.01%)
/availability 155.45 KB 388.78 KB 111.08% (+/- <0.01%)
/availability/[schedule] 272.21 KB 505.54 KB 144.44% (+/- <0.01%)
/availability/troubleshoot 152.83 KB 386.16 KB 110.33% (+/- <0.01%)
/booking/[uid] 123.63 KB 356.96 KB 101.99% (+/- <0.01%)
/bookings/[status] 272.53 KB 505.86 KB 144.53% (+/- <0.01%)
/d/[link]/[slug] 91.59 KB 324.92 KB 92.83% (+/- <0.01%)
/d/[link]/[slug]/embed 91.62 KB 324.95 KB 92.84% (+/- <0.01%)
/event-types/[type] 383.16 KB 616.48 KB 176.14% (+/- <0.01%)
/insights 387.3 KB 620.62 KB 177.32% (+/- <0.01%)
/more 151.77 KB 385.1 KB 110.03% (+/- <0.01%)
/settings/admin 157.23 KB 390.55 KB 111.59% (+/- <0.01%)
/settings/admin/apps 165.91 KB 399.24 KB 114.07% (+/- <0.01%)
/settings/admin/apps/[category] 165.9 KB 399.22 KB 114.06% (+/- <0.01%)
/settings/admin/flags 160.12 KB 393.45 KB 112.41% (+/- <0.01%)
/settings/admin/impersonation 157.51 KB 390.83 KB 111.67% (+/- <0.01%)
/settings/billing 157.34 KB 390.66 KB 111.62% (+/- <0.01%)
/settings/developer/api-keys 186.49 KB 419.82 KB 119.95% (+/- <0.01%)
/settings/developer/webhooks 159.99 KB 393.32 KB 112.38% (+/- <0.01%)
/settings/developer/webhooks/[id] 190.68 KB 424.01 KB 121.15% (+/- <0.01%)
/settings/developer/webhooks/new 190.54 KB 423.87 KB 121.10% (🟡 +0.01%)
/settings/my-account/appearance 171.3 KB 404.63 KB 115.61% (+/- <0.01%)
/settings/my-account/calendars 191.53 KB 424.85 KB 121.39% (+/- <0.01%)
/settings/my-account/conferencing 163.15 KB 396.47 KB 113.28% (+/- <0.01%)
/settings/my-account/general 266.49 KB 499.82 KB 142.81% (+/- <0.01%)
/settings/my-account/profile 274.31 KB 507.64 KB 145.04% (+/- <0.01%)
/settings/security/impersonation 159.38 KB 392.7 KB 112.20% (+/- <0.01%)
/settings/security/password 192.67 KB 426 KB 121.71% (+/- <0.01%)
/settings/security/sso 167.07 KB 400.4 KB 114.40% (+/- <0.01%)
/settings/security/two-factor-auth 161.89 KB 395.22 KB 112.92% (+/- <0.01%)
/settings/teams 156.97 KB 390.3 KB 111.51% (+/- <0.01%)
/settings/teams/[id]/appearance 171.32 KB 404.65 KB 115.61% (+/- <0.01%)
/settings/teams/[id]/billing 157.21 KB 390.53 KB 111.58% (+/- <0.01%)
/settings/teams/[id]/members 297.3 KB 530.63 KB 151.61% (+/- <0.01%)
/settings/teams/[id]/profile 269.53 KB 502.85 KB 143.67% (+/- <0.01%)
/settings/teams/[id]/sso 167.17 KB 400.49 KB 114.43% (+/- <0.01%)
/signup 25.5 KB 258.82 KB 73.95% (+/- <0.01%)
/team/[slug] 72.62 KB 305.94 KB 87.41% (+/- <0.01%)
/team/[slug]/[type] 91.6 KB 324.92 KB 92.83% (🟡 +0.01%)
/team/[slug]/[type]/embed 91.63 KB 324.95 KB 92.84% (+/- <0.01%)
/team/[slug]/embed 72.68 KB 306.01 KB 87.43% (+/- <0.01%)
/teams 151.99 KB 385.31 KB 110.09% (+/- <0.01%)
/video/meeting-ended/[uid] 14.67 KB 247.99 KB 70.85% (🟡 +0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.63 KB 70.75% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.93 KB 68.55% (+/- <0.01%)
/workflows 164.93 KB 398.26 KB 113.79% (+/- <0.01%)
/workflows/[workflow] 294.1 KB 527.42 KB 150.69% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Apr 2, 2023

@saideepesh000 can you record a loom demo?

@PeerRich PeerRich merged commit 283d5b4 into calcom:main Apr 2, 2023
@saideepesh000
Copy link
Copy Markdown
Contributor Author

@saideepesh000 can you record a loom demo?

so sorry @PeerRich ,now seeing this, will update with screenshots/recordings from next PR onwards(if required)

@hariombalhara
Copy link
Copy Markdown
Member

hariombalhara commented Apr 4, 2023

@saideepesh000 It broke full width, darkmode for Email field and Form Submission itself. Fix is up here #8074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use EmailField component for Routing Form Email field

3 participants