Skip to content

Fixes duplicate New button in /workflows#8058

Merged
emrysal merged 1 commit intomainfrom
fix/double-new-workflow-button
Apr 3, 2023
Merged

Fixes duplicate New button in /workflows#8058
emrysal merged 1 commit intomainfrom
fix/double-new-workflow-button

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Fixes duplicate new button and not needed filter in /workflows. It was introduced by #8038

Before:
Screenshot 2023-04-03 at 13 30 32

After:
Screenshot 2023-04-03 at 13 29 51

@CarinaWolli CarinaWolli requested a review from a team April 3, 2023 11:31
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 11:37am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 11:37am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.34 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/workflows 164.99 KB 398.34 KB 113.81% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@emrysal emrysal merged commit db4449d into main Apr 3, 2023
@emrysal emrysal deleted the fix/double-new-workflow-button branch April 3, 2023 12:34
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants