Skip to content

fix: flash of grey when navigating to workflow page#8038

Merged
CarinaWolli merged 5 commits intomainfrom
fix-workflow-grey
Apr 3, 2023
Merged

fix: flash of grey when navigating to workflow page#8038
CarinaWolli merged 5 commits intomainfrom
fix-workflow-grey

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Mar 31, 2023

What does this PR do?

before:

Screencast.2023-03-31.14.56.04.webm

after:

Screencast.2023-03-31.14.54.34.webm

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@G3root G3root requested a review from CarinaWolli as a code owner March 31, 2023 09:28
@G3root G3root requested a review from a team March 31, 2023 09:28
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) Apr 3, 2023 9:17am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 9:17am

}
}, [session.status, query.isLoading, allWorkflowsData]);

if (!query.data) return null;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed early return, this was causing the flash

query?.data?.profiles.length &&
allWorkflowsData?.workflows &&
allWorkflowsData.workflows.length &&
profileOptions ? (
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used ternary operator to prevent rendering 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.34 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/workflows 164.99 KB 398.33 KB 113.81% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Mar 31, 2023

No failed tests 🎉

@PeerRich PeerRich added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work High priority Created by Linear-GitHub Sync labels Apr 2, 2023
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels so much snappier <3

@CarinaWolli CarinaWolli merged commit 9d61dc2 into main Apr 3, 2023
@CarinaWolli CarinaWolli deleted the fix-workflow-grey branch April 3, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants