Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Udit-takkar
commented
Feb 25, 2023
Comment on lines
+93
to
+95
| email: calEventRaw.destinationCalendar?.externalId | ||
| ? calEventRaw.destinationCalendar.externalId | ||
| : calEventRaw.organizer.email, |
Contributor
Author
There was a problem hiding this comment.
the event was created twice because google adds the event to all attendees email primary calendar. so if a user has a secondary calendar as destination calendar he would see event created on both primary and secondary calendar. we can avoid adding event to primary calendar by simply not passing email here
G3root
pushed a commit
that referenced
this pull request
Mar 2, 2023
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
dmkav
pushed a commit
to join-com/cal-com
that referenced
this pull request
Mar 6, 2023
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5588, #7329
Do suggest if there are better approach to fix these issues
BEFORE:-
AFTER:-
Environment: Staging(main branch) / Production
Type of change