Allow user to add as many locations as they want#7279
Merged
hariombalhara merged 16 commits intocalcom:mainfrom Feb 23, 2023
esau-morais:main
Merged
Allow user to add as many locations as they want#7279hariombalhara merged 16 commits intocalcom:mainfrom esau-morais:main
hariombalhara merged 16 commits intocalcom:mainfrom
esau-morais:main
Conversation
|
@esau-morais is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
| </div> | ||
| )} | ||
| {validLocations.length > 0 && validLocations.length !== locationOptions.length && ( | ||
| {validLocations.length > 0 && ( |
Member
There was a problem hiding this comment.
This check was actually there to stop showing 'Add a Location' CTA when all possible locations are added. Something has broken it. But for now it is acceptable.
hariombalhara
approved these changes
Feb 23, 2023
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Feb 26, 2023
Mythie
pushed a commit
to Mythie/cal.com
that referenced
this pull request
Mar 5, 2023
dmkav
pushed a commit
to join-com/cal-com
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #7138
Proof
The conclusion I've made is that when
locationsget the exact length as thelocationOptions, it doesn't fit the removed condition (validLocations !== locationOptions), once they are equal, which causes the issue.Type of change
How should this be tested?
Checklist