Conversation
added 13 commits
January 13, 2023 16:24
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
CarinaWolli
commented
Jan 19, 2023
| setText={(value: string) => setValue("bio", value)} | ||
| excludedToolbarItems={["blockType"]} | ||
| /> | ||
| {errors.bio && ( |
Member
Author
There was a problem hiding this comment.
As discussed with @Jaibles, we are making 'about' optional when onboarding (also optional in settings)
packages/lib/getInnerText.tsx
Outdated
| @@ -0,0 +1,6 @@ | |||
| export const getInnerText = (node: string | JSX.Element | JSX.Element[]): string => { | |||
Member
Author
There was a problem hiding this comment.
helper function to get text without html tags (used to see if bio is empty)
zomars
reviewed
Jan 19, 2023
apps/web/components/getting-started/steps-views/UserProfile.tsx
Outdated
Show resolved
Hide resolved
zomars
reviewed
Jan 19, 2023
zomars
reviewed
Jan 19, 2023
zomars
reviewed
Jan 19, 2023
CarinaWolli
commented
Jan 24, 2023
| turndownService.addRule("newLine", { | ||
| filter: ["br"], | ||
| replacement: () => { | ||
| return "<p><br></p>"; |
Member
Author
There was a problem hiding this comment.
allows to add blank lines
Member
Author
|
PR is ready for review again @zomars The user and team bio is now saved as markdown instead of HTML |
zomars
reviewed
Jan 24, 2023
zomars
reviewed
Jan 24, 2023
zomars
reviewed
Jan 24, 2023
Contributor
zomars
left a comment
There was a problem hiding this comment.
Looking good @CarinaWolli just some nitpicks and orphan imports to merge
Co-authored-by: Omar López <zomars@me.com>
zomars
added a commit
that referenced
this pull request
Jan 26, 2023
* use texteditor for bio * remove block types from about editor * add props to make editor height adjustable * set isDirty to true when about input is edited * add editor to getting-started * fix editor height * remove required error for onboarding * add helper function to check if parsed bio has text * add back commented code * fix onboarding tests for optional about field * rename function * parse team bio for read only members * code clean up * fix failing e2e because of missing test id * fix onboarding e2e test * add missing parse of user bio * Update apps/web/components/getting-started/steps-views/UserProfile.tsx * Update apps/web/pages/settings/my-account/profile.tsx Co-authored-by: Omar López <zomars@me.com> * use css inline style for height instead of tailwind class * fix height of editor-input * save bio as markdown in db * fix empty line when bio is empty * fix hydration failed error * Update packages/ui/components/editor/Editor.tsx Co-authored-by: Omar López <zomars@me.com> * remove unused import Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com>
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jan 27, 2023
* use texteditor for bio * remove block types from about editor * add props to make editor height adjustable * set isDirty to true when about input is edited * add editor to getting-started * fix editor height * remove required error for onboarding * add helper function to check if parsed bio has text * add back commented code * fix onboarding tests for optional about field * rename function * parse team bio for read only members * code clean up * fix failing e2e because of missing test id * fix onboarding e2e test * add missing parse of user bio * Update apps/web/components/getting-started/steps-views/UserProfile.tsx * Update apps/web/pages/settings/my-account/profile.tsx Co-authored-by: Omar López <zomars@me.com> * use css inline style for height instead of tailwind class * fix height of editor-input * save bio as markdown in db * fix empty line when bio is empty * fix hydration failed error * Update packages/ui/components/editor/Editor.tsx Co-authored-by: Omar López <zomars@me.com> * remove unused import Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com>
|
very nice! |
Member
|
@shirazdole casually replying to a 3 week old PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ability to format user and team bio (bold, italic, link and multi line) by using our already existing
<Editor>component.User bio:
Team bio:
Fixes #6204
Environment: Staging(main branch)