Skip to content

Fix min booking notice#4679

Merged
emrysal merged 2 commits intomainfrom
4678-event-type-limits-minimum-notice-period-does-not-appear-to-be-saving
Sep 23, 2022
Merged

Fix min booking notice#4679
emrysal merged 2 commits intomainfrom
4678-event-type-limits-minimum-notice-period-does-not-appear-to-be-saving

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Sep 23, 2022

Fixes min booking notice

Adds minute field as a v2 field component

After:

CleanShot 2022-09-23 at 13 00 58@2x

GIF:

CleanShot 2022-09-23 at 13 01 36

@sean-brydon sean-brydon linked an issue Sep 23, 2022 that may be closed by this pull request
/event type /limits - Minimum notice period does not appear to be saving #4678
Closed
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 1:55PM (UTC)

emrysal
emrysal requested changes Sep 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextField was saving but there was an uncommitted change in the event-types/[type].tsx (defaultValues) - This field should be uncontrolled, will make amends.

@emrysal emrysal self-requested a review September 23, 2022 13:46
@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Sep 23, 2022

  • The MinutesField is now uncontrolled
  • defaultValue properly supplied (cause of the error)
  • Ring offset has been adjusted to mirror the normal TextField (We may need to offset-1 the Selects)

@emrysal emrysal enabled auto-merge (squash) September 23, 2022 13:54
@emrysal emrysal added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 23, 2022
@emrysal emrysal merged commit 682f0c6 into main Sep 23, 2022
@emrysal emrysal deleted the 4678-event-type-limits-minimum-notice-period-does-not-appear-to-be-saving branch September 23, 2022 14:00
emrysal added a commit that referenced this pull request Sep 23, 2022
@sean-brydon @emrysal
Fix min booking notice (#4679)
4ae13dc 
* Fix miniumbookig notice

* Fixes minutes field not working properly (#4680)

Co-authored-by: Alex van Andel <me@alexvanandel.com>
emrysal added a commit that referenced this pull request Sep 23, 2022
@emrysal @sean-brydon
Fix min booking notice (#4679) (#4681)
4d31af8 
* Fix miniumbookig notice

* Fixes minutes field not working properly (#4680)

Co-authored-by: Alex van Andel <me@alexvanandel.com>

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

Assignees

No one assigned

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

No open projects
Cal.com Core Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

/event type /limits - Minimum notice period does not appear to be saving

2 participants

@sean-brydon @emrysal