Skip to content

Avoid creating dynamic HTML#4669

Merged
hariombalhara merged 1 commit intomainfrom
hotfix/security-issue
Sep 22, 2022
Merged

Avoid creating dynamic HTML#4669
hariombalhara merged 1 commit intomainfrom
hotfix/security-issue

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Sep 22, 2022

What does this PR do?

Fixes # (issue)
Avoid creating dynamic HTML
See private thread https://twist.com/a/195135/ch/589886/t/3785097/ for more details

With this change we are missing the functionality of making the first part of the text bold, which isn't that important. We can figure it out later if that is really good to have.

After the change
Screenshot 2022-09-22 at 5 04 39 PM

Before the change
Screenshot 2022-09-22 at 5 05 47 PM

Environment: Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 11:41AM (UTC)

@hariombalhara hariombalhara merged commit f628ac4 into main Sep 22, 2022
@hariombalhara hariombalhara deleted the hotfix/security-issue branch September 22, 2022 13:43
emrysal pushed a commit that referenced this pull request Sep 22, 2022
hariombalhara added a commit that referenced this pull request Sep 22, 2022
Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants