Run available user check if event type does not have seats#4646
Merged
Run available user check if event type does not have seats#4646
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joeauyeung
commented
Sep 21, 2022
| checked={seatsInputVisible} | ||
| onCheckedChange={(e) => { | ||
| setSeatsInputVisible(e); | ||
| formMethods.setValue("seatsPerTimeSlot", seatsPerTimeSlot); |
Contributor
Author
There was a problem hiding this comment.
Set default seats on event type when switch is clicked
|
|
||
| // Add an if conditional if there are no seats on the event type | ||
| // Assign to only one user when ROUND_ROBIN | ||
| if (!eventType.seatsPerTimeSlot) { |
Contributor
Author
There was a problem hiding this comment.
We should only run ensureAvailableUsers if there are no seats. Currently since the user that made the event type is counted as "booked" if there is already one attendee.
emrysal
approved these changes
Sep 21, 2022
joeauyeung
added a commit
that referenced
this pull request
Sep 21, 2022
* Move available users if there are no seats * Fix adding default seat to event type Co-authored-by: Alex van Andel <me@alexvanandel.com>
emrysal
added a commit
that referenced
this pull request
Sep 21, 2022
* Move available users if there are no seats * Fix adding default seat to event type Co-authored-by: Alex van Andel <me@alexvanandel.com>
emrysal
added a commit
that referenced
this pull request
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Available users should be run if there are no seats on the event type.
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist