Skip to content

revert: onboarding v3 global#27933

Merged
volnei merged 1 commit intomainfrom
revert/v3-globally
Feb 13, 2026
Merged

revert: onboarding v3 global#27933
volnei merged 1 commit intomainfrom
revert/v3-globally

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Feb 13, 2026

Summary by cubic

Reverts the global enablement of Onboarding v3 and aligns tests to the current /getting-started flow. Removes the enabling migration and stabilizes onboarding redirects and e2e coverage.

  • Migration

    • Removed the migration that enabled the onboarding-v3 feature globally.
  • Refactors

    • Standardized redirects and tests to /getting-started (e.g., connected-calendar, connected-video, setup-availability, user-profile).
    • Replaced use of data-testid="onboarding-continue-btn" with specific, existing step buttons and checks.
    • Updated signup/invite tests to wait for /getting-started and the welcome screen.
    • Minor test cleanups (import ordering, route expectations).

Written for commit 621dad2. Summary will update on new commits.

@sean-brydon sean-brydon requested a review from a team as a code owner February 13, 2026 12:02
@github-actions github-actions bot added the ❗️ migrations contains migration files label Feb 13, 2026
@graphite-app graphite-app bot added consumer core area: core, team members only labels Feb 13, 2026
@graphite-app graphite-app bot requested a review from a team February 13, 2026 12:02
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@volnei volnei enabled auto-merge (squash) February 13, 2026 12:03
@paragon-review
Copy link
Copy Markdown

Paragon: tests updated

4 updated tests generated for this PR.

Updated Tests

  • OnboardingView component tests (data-testid removal, routing, plan filtering) — Tests the OnboardingView component after the v3 revert. Covers: rendering with/without company emails, data-testid='onboarding-continue-btn' removal verification, plan filtering (2 plans for personal vs 3 for company), handleContinue routing to correct paths, PlanIcon display for each plan type, loading state during membership check, team membership redirect behavior, onboarding reset on mount, and edge cases like empty email.
  • PersonalCalendarView component tests (data-testid removal, buttons, loading) — Tests the PersonalCalendarView component after data-testid='onboarding-continue-btn' removal. Covers: layout rendering at correct step, calendar connection card display, calendar browser view, app card rendering for integrations, footer buttons (back/skip/continue) with correct handlers, loading state passing to OnboardingCard, button disabled states during loading, empty data handling, integration query params, and floating footer prop.
  • Onboarding URL routing pattern tests (classic vs v3 routes) — Validates the URL routing patterns after v3 revert. Tests that classic /getting-started routes are used, v3 /onboarding/... routes are excluded from redirect assertions, post-signup redirect patterns are simplified, invite link signup redirects use simple URLs instead of regex, AB test paths use /getting-started/connected-calendar, and the classic 5-step onboarding flow with correct test IDs.
  • Onboarding V3 revert verification tests (file-level checks) — File-level verification tests for the v3 revert. Checks: data-testid removal from both source files while preserving button functionality, migration SQL file deletion, E2E test files using classic routes and test IDs, test name changes from 'v3' to generic, simplified URL patterns in signup/auth/invitation tests, and correct import ordering per biome formatting.

Accept Changes Open in Paragon

Details

Updated Tests

  • OnboardingView component tests (data-testid removal, routing, plan filtering) (unit)
  • PersonalCalendarView component tests (data-testid removal, buttons, loading) (unit)
  • Onboarding URL routing pattern tests (classic vs v3 routes) (unit)
  • Onboarding V3 revert verification tests (file-level checks) (unit)

@volnei volnei merged commit 227ed64 into main Feb 13, 2026
90 of 97 checks passed
@volnei volnei deleted the revert/v3-globally branch February 13, 2026 12:14
sean-brydon added a commit that referenced this pull request Feb 13, 2026
This reverts commit 227ed64.
anikdhabal pushed a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ❗️ migrations contains migration files ready-for-e2e size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants