Skip to content

fix: Editing RR weights adds all hosts#22623

Merged
emrysal merged 3 commits intocalcom:mainfrom
romitg2:cal-6125
Jul 18, 2025
Merged

fix: Editing RR weights adds all hosts#22623
emrysal merged 3 commits intocalcom:mainfrom
romitg2:cal-6125

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Jul 18, 2025 •
edited
Loading

Visual Demo (For contributors especially)

After:

Screen.Recording.2025-07-18.at.4.24.20.PM.mov

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 18, 2025

@romitg2 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 18, 2025 •
edited
Loading

Walkthrough

The change updates the logic in the handleSave function within the EditWeightsForAllTeamMembers.tsx component. Specifically, when constructing the updatedValue array, the code now checks if each team member has a corresponding entry in existingHostsMap. If a team member does not have an existing host, the mapping returns null. After mapping, the array is filtered to remove any falsy values, ensuring that only team members with existing hosts are included in the final array passed to onChange. No exported or public entity declarations were altered.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/features/eventtypes/components/EditWeightsForAllTeamMembers.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf39256 and 3d3fd6f.

📒 Files selected for processing (1)
  • packages/features/eventtypes/components/EditWeightsForAllTeamMembers.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Install dependencies / Yarn install & cache
  • GitHub Check: Security Check
🔇 Additional comments (2)
packages/features/eventtypes/components/EditWeightsForAllTeamMembers.tsx (2)

149-161: Good fix for preventing unintended host additions.

The conditional check and filtering logic correctly addresses the bug where all team members were being added as hosts during weight editing. The approach of returning null for non-existent hosts and filtering them out ensures only legitimate hosts are updated.

149-161: Ensure test coverage for the new filtering logic.

The conditional check and filtering logic should be thoroughly tested to cover edge cases such as:

  • Team members with no existing hosts (should be filtered out)
  • Mixed scenarios where some team members have existing hosts and others don't
  • Empty existingHostsMap scenarios

Please verify that automated tests cover these scenarios as mentioned in the PR objectives.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jul 18, 2025
@graphite-app graphite-app bot requested a review from a team July 18, 2025 10:51
@github-actions github-actions bot added consumer teams area: teams, round robin, collective, managed event-types ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers 🐛 bug Something isn't working labels Jul 18, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Jul 18, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/18/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (07/18/25)

1 label was added to this PR based on Keith Williams's automation.

Devanshusharma2005
Devanshusharma2005 approved these changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Devanshusharma2005 Devanshusharma2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025

E2E results are ready!

emrysal
emrysal approved these changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emrysal emrysal merged commit e1d7631 into calcom:main Jul 18, 2025
57 of 62 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jul 22, 2025
Merged
zomars pushed a commit that referenced this pull request Jul 22, 2025
@romitg2 @zomars
fix: Editing RR weights adds all hosts (#22623)
8982961 
* fixed

* chore

* chore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

+1 more reviewer

@Devanshusharma2005 Devanshusharma2005 Devanshusharma2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync consumer ✅ good first issue Good for newcomers ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ready-for-e2e teams area: teams, round robin, collective, managed event-types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Editing RR weights adds all hosts

3 participants

@romitg2 @emrysal @Devanshusharma2005