Skip to content

Revert "feat: add race condition test for calendar-cache-serve booking flow"#22400

Merged
zomars merged 1 commit intomainfrom
revert-22170-devin/1751323069-reproduce-booking-race-condition
Jul 11, 2025
Merged

Revert "feat: add race condition test for calendar-cache-serve booking flow"#22400
zomars merged 1 commit intomainfrom
revert-22170-devin/1751323069-reproduce-booking-race-condition

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Jul 11, 2025 •
edited by cubic-dev-ai bot
Loading

Reverts #22170

Summary by cubic

Removed the end-to-end test for race condition prevention in the calendar cache booking flow by deleting the related Playwright test file.

@vercel vercel bot temporarily deployed to Preview – api July 11, 2025 00:37 Inactive
@vercel
Copy link
Copy Markdown

vercel bot commented Jul 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2025 0:37am
cal-eu ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2025 0:37am

@graphite-app graphite-app bot requested a review from a team July 11, 2025 00:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Revert "feat: add race condition test for calendar-cache-serve booking flow"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only foundation labels Jul 11, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Jul 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed this PR and found no issues. Review PR in cubic.dev.

@delve-auditor
Copy link
Copy Markdown

delve-auditor bot commented Jul 11, 2025

✅ No security or compliance issues detected. Reviewed everything up to 5a3a68c.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Refactor ► booking-race-condition.e2e.ts
    Remove race condition test for calendar-cache-serve booking flow

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Jul 11, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (07/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@zomars zomars merged commit 2fb2458 into main Jul 11, 2025
56 of 61 checks passed
@zomars zomars deleted the revert-22170-devin/1751323069-reproduce-booking-race-condition branch July 11, 2025 00:43
@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Jul 11, 2025
@zomars zomars mentioned this pull request Jul 11, 2025
Merged
3 tasks
Arephan pushed a commit to Arephan/cal.com that referenced this pull request Jul 11, 2025
@zomars @Arephan
Revert "feat: add race condition test for calendar-cache-serve bookin…
4c68a53 
…g flow (…" (calcom#22400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

automated-tests area: unit tests, e2e tests, playwright core area: core, team members only foundation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zomars @keithwillcode