feat: Add routing-forms record response endpoint with available slots by hariombalhara · Pull Request #22239 · calcom/cal.com

hariombalhara · 2025-07-03T11:52:54Z

What does this PR do?

Added a new API endpoint to create a routing form response(POST v2/organizations/:orgId/routing-forms/:formId/responses) and returns available booking slots for the matched event type. The response from that endpoint could be utilised to do a booking for a particular timeslot and connect that with the routingForm response

How to connect a response with booking

Send POST request to https://api.cal.com/v2/organizations/:orgId/routing-forms/:formId/responses?start=2025-06-30T18:30:00.000Z&end=2025-07-23T09:00:00Z with JSON body

{
  "email": "john@example.com",  // email is a field in Routing Form with _identifier_=_email_
}

It will return a response like

{
    "status": "success",
    "data": {
        "routing": {
            "responseId": 476,
            "teamMemberIds": [
                19,
                21,
                22,
                25,
                26
            ],
            ... more props here
        },
        "eventTypeId": 56,
        "slots": {
            "2025-07-04": [
                {
                    "start": "2025-07-04T12:00:00.000Z"
                }
			]    
         }
    }
}

The routing object and eventTypeId and any slot available in slots can be used to create a booking now through
https://api.cal.com/v2/bookings (documented here) endpoint. You can pass the routing object as is. Take a look at this loom to see it all working

Followup

A new endpoint to use the queued response identified by queuedResponseId

Video Demo (if applicable):

https://www.loom.com/share/db67e598548b42789b7072a2e9996057

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

vercel · 2025-07-03T11:52:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jul 4, 2025 11:59am
cal-eu	⬜️ Ignored (Inspect)	Visit Preview		Jul 4, 2025 11:59am

hariombalhara · 2025-07-03T11:53:13Z

feat: Add routing-forms record response endpoint with available slots #22239 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

delve-auditor · 2025-07-03T11:56:25Z

✅ No security or compliance issues detected. Reviewed everything up to 889dd32.

Security Overview

🔎 Scanned files: 23 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► input.service.ts Add routing form data processing ► organizations-routing-forms-responses.controller.ts Add endpoint for creating routing form responses ► organizations-routing-forms-responses.service.ts Add routing form response handling ► handleResponse.ts Add support for identifier keyed responses and CRM routing ► getRoutedUrl.ts Add configurable CRM fetching
Configuration changes	► package.json Update platform libraries version
Refactor	► routerGetCrmContactOwnerEmail.ts Refactor email extraction logic ► swagger/documentation.json Update API documentation

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

github-actions · 2025-07-03T13:40:50Z

E2E results are ready!

Workflow #65936.2 latest results

- Fix type mismatch where mockResponse was passed as identifierKeyedResponse - identifierKeyedResponse expects Record<string, string | string[]> structure - Updated test to pass correct data structure for type compatibility Co-Authored-By: hariom@cal.com <hariom@cal.com>

@query

…g in routing forms responses controller - Change @query() to @Body() decorator for POST request data in controller - Update service method to accept parsed body data directly - Remove incorrect URLSearchParams parsing of request.body object - Fix getRoutingUrl method to use form response data parameter This resolves API v2 test failures by following proper NestJS patterns for POST request handling. Co-Authored-By: hariom@cal.com <hariom@cal.com>

hariombalhara · 2025-07-03T15:26:30Z

packages/app-store/routing-forms/lib/crmRouting/routerGetCrmContactOwnerEmail.ts


 export default async function routerGetCrmContactOwnerEmail({
  attributeRoutingConfig,
-  response,


Bug-1: The response contains id of the field as they key and not the identifier. So we need to pass the one with identifier as they key here.

The one with id of the field, doesn't have the identifier anywhere and thus can't be compared with email identifier

hariombalhara · 2025-07-03T15:26:53Z

packages/app-store/routing-forms/lib/crmRouting/routerGetCrmContactOwnerEmail.ts

+    for (const identifier of Object.keys(identifierKeyedResponse)) {
+      const fieldResponse = identifierKeyedResponse[identifier];
+      if (identifier === "email") {
+        prospectEmail = fieldResponse instanceof Array ? fieldResponse[0] : fieldResponse;
+        break;
+      }


Logic changed as per the new response object which is identifier key based.

hariombalhara · 2025-07-03T15:28:19Z

packages/app-store/routing-forms/lib/crmRouting/routerGetCrmContactOwnerEmail.ts

  }

-  if (!contactOwner) {
+  if (!contactOwner || (!contactOwner.email && !contactOwner.recordType)) {


Bug-2: contactOwner by default isn't null. See line 43. So, we must consider it as nullish if both email and recordType are nullish

...odules/organizations/routing-forms/services/organizations-routing-forms-responses.service.ts

ThyMinimalDev · 2025-07-03T15:35:57Z

packages/lib/server/getRoutedUrl.ts

      form: serializableForm,
      formFillerId: uuidv4(),
      response: response,
+      identifierKeyedResponse: fieldsResponses,


we need to release platform libraries

packages/platform/types/slots/slots-2024-09-04/inputs/get-slots.input.ts

apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/user-bookings.e2e-spec.ts

.../organizations/routing-forms/controllers/organizations-routing-forms-responses.controller.ts

ThyMinimalDev · 2025-07-03T15:40:23Z

.../organizations/routing-forms/controllers/organizations-routing-forms-responses.controller.ts

+
+    return {
+      status: SUCCESS_STATUS,
+      data: result,


if we need to control and hide fields that are not within the DTO use plainToClass combined with @Expose decorator in output DTO class

...odules/organizations/routing-forms/services/organizations-routing-forms-responses.service.ts

hariombalhara · 2025-07-03T15:43:34Z

apps/api/v2/src/modules/router/controllers/router.controller.ts

+      if (routedUrlData.props.errorMessage) {
+        return {
+          status: "error",
+          error: { code: "ROUTING_ERROR", message: routedUrlData.props.errorMessage },
+          redirect: false,
+        };


This fixes an existing case where in case of form field validation failure, we were still returning success with empty message.

packages/platform/types/slots/slots-2024-09-04/inputs/get-slots.input.ts

hariombalhara · 2025-07-04T10:58:08Z

packages/app-store/routing-forms/lib/handleResponse.ts

-              action: chosenRoute.action,
-            });
+            const contactOwnerQuery =
+              identifierKeyedResponse && fetchCrm


@joeauyeung By default having this variable as false, so that we intentionally not use the fixed logic for headless router or elsewhere except API v2's new endpoint.

This keeps the behaviour same for headless router as routerGetCrmContactOwnerEmail wasn't returning any contactOwner or other details

socket-security · 2025-07-04T10:59:29Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	memory-cache@0.2.0
	bcryptjs@2.4.3

View full report

graphite-app · 2025-07-04T11:40:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

cubic-dev-ai

cubic found 6 issues across 23 files. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

apps/api/v2/src/modules/slots/slots-2024-09-04/services/slots-input.service.ts

apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts

...pi/v2/src/modules/organizations/routing-forms/outputs/create-routing-form-response.output.ts

apps/api/v2/src/modules/router/controllers/router.controller.ts

apps/api/v2/test/fixtures/repository/api-keys.repository.fixture.ts

@query

…#22239) * feat: Add routing-forms record response endpoint with available slots * fix: resolve TypeScript error in handleResponse.test.ts - Fix type mismatch where mockResponse was passed as identifierKeyedResponse - identifierKeyedResponse expects Record<string, string | string[]> structure - Updated test to pass correct data structure for type compatibility Co-Authored-By: hariom@cal.com <hariom@cal.com> * fix: correct POST endpoint parameter handling and request body parsing in routing forms responses controller - Change @query() to @Body() decorator for POST request data in controller - Update service method to accept parsed body data directly - Remove incorrect URLSearchParams parsing of request.body object - Fix getRoutingUrl method to use form response data parameter This resolves API v2 test failures by following proper NestJS patterns for POST request handling. Co-Authored-By: hariom@cal.com <hariom@cal.com> * Pass teamMemberEmail as well * Devin fixes reverted * Keep all routing related props together in both endpoints * Remove newly added slots props from Slots documentation as they are used through internal fn call only * fix test * Pass skipContactOwner * Pass crmAppSlug and crmOwnerRecordGType and add more tests * handle external redirect case and form not found case * hide props * chore: bump platform libs --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: hariom@cal.com <hariom@cal.com> Co-authored-by: cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>

@query

…#22239) * feat: Add routing-forms record response endpoint with available slots * fix: resolve TypeScript error in handleResponse.test.ts - Fix type mismatch where mockResponse was passed as identifierKeyedResponse - identifierKeyedResponse expects Record<string, string | string[]> structure - Updated test to pass correct data structure for type compatibility Co-Authored-By: hariom@cal.com <hariom@cal.com> * fix: correct POST endpoint parameter handling and request body parsing in routing forms responses controller - Change @query() to @Body() decorator for POST request data in controller - Update service method to accept parsed body data directly - Remove incorrect URLSearchParams parsing of request.body object - Fix getRoutingUrl method to use form response data parameter This resolves API v2 test failures by following proper NestJS patterns for POST request handling. Co-Authored-By: hariom@cal.com <hariom@cal.com> * Pass teamMemberEmail as well * Devin fixes reverted * Keep all routing related props together in both endpoints * Remove newly added slots props from Slots documentation as they are used through internal fn call only * fix test * Pass skipContactOwner * Pass crmAppSlug and crmOwnerRecordGType and add more tests * handle external redirect case and form not found case * hide props * chore: bump platform libs --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: hariom@cal.com <hariom@cal.com> Co-authored-by: cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>

keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jul 3, 2025

hariombalhara force-pushed the routing-forms-record-endpoint branch from 74a7400 to 306bf01 Compare July 3, 2025 12:07

hariombalhara added the ready-for-e2e label Jul 3, 2025

hariombalhara force-pushed the routing-forms-record-endpoint branch from 306bf01 to 1fac0f9 Compare July 3, 2025 12:35

vercel bot deployed to Preview – dev July 3, 2025 12:53 View deployment

hariombalhara force-pushed the routing-forms-record-endpoint branch from 1fac0f9 to 6b93fd0 Compare July 3, 2025 12:57

vercel bot deployed to Preview – dev July 3, 2025 13:33 View deployment

vercel bot temporarily deployed to Preview – api July 3, 2025 14:22 Inactive

vercel bot temporarily deployed to Preview – cal July 3, 2025 14:22 Inactive

vercel bot deployed to Preview – dev July 3, 2025 14:40 View deployment

vercel bot temporarily deployed to Preview – api July 3, 2025 14:51 Inactive

vercel bot temporarily deployed to Preview – cal July 3, 2025 14:51 Inactive

vercel bot deployed to Preview – dev July 3, 2025 15:16 View deployment

hariombalhara and others added 3 commits July 3, 2025 20:54

feat: Add routing-forms record response endpoint with available slots

e289a08

hariombalhara force-pushed the routing-forms-record-endpoint branch from 00348e5 to 5f935ea Compare July 3, 2025 15:25

hariombalhara commented Jul 3, 2025

View reviewed changes

ThyMinimalDev previously requested changes Jul 3, 2025

View reviewed changes

hariombalhara commented Jul 3, 2025

View reviewed changes

vercel bot deployed to Preview – dev July 3, 2025 16:05 View deployment

hariombalhara added 2 commits July 3, 2025 21:41

Pass teamMemberEmail as well

963225f

Devin fixes reverted

7661f49

ThyMinimalDev reviewed Jul 4, 2025

View reviewed changes

packages/platform/types/slots/slots-2024-09-04/inputs/get-slots.input.ts Show resolved Hide resolved

ThyMinimalDev reviewed Jul 4, 2025

View reviewed changes

packages/platform/types/slots/slots-2024-09-04/inputs/get-slots.input.ts Show resolved Hide resolved

hariombalhara added 2 commits July 4, 2025 16:13

handle external redirect case and form not found case

63f1751

hide props

c63a7d8

hariombalhara force-pushed the routing-forms-record-endpoint branch from de0bb41 to c63a7d8 Compare July 4, 2025 10:52

chore: bump platform libs

b5fc13f

vercel bot temporarily deployed to Preview – api July 4, 2025 10:57 Inactive

vercel bot temporarily deployed to Preview – cal July 4, 2025 10:57 Inactive

hariombalhara commented Jul 4, 2025

View reviewed changes

vercel bot deployed to Preview – dev July 4, 2025 11:29 View deployment

hariombalhara marked this pull request as ready for review July 4, 2025 11:39

hariombalhara requested a review from a team July 4, 2025 11:39

hariombalhara requested a review from a team as a code owner July 4, 2025 11:39

graphite-app bot requested a review from a team July 4, 2025 11:39

dosubot bot added api area: API, enterprise API, access token, OAuth routing-forms area: routing forms, routing, forms ✨ feature New feature or request labels Jul 4, 2025

cubic-dev-ai bot reviewed Jul 4, 2025

View reviewed changes

Merge branch 'main' into routing-forms-record-endpoint

889dd32

ThyMinimalDev approved these changes Jul 4, 2025

View reviewed changes

hariombalhara enabled auto-merge (squash) July 4, 2025 12:01

vercel bot deployed to Preview – dev July 4, 2025 12:18 View deployment

hariombalhara merged commit 056b821 into main Jul 4, 2025
64 of 66 checks passed

hariombalhara deleted the routing-forms-record-endpoint branch July 4, 2025 12:33

This was referenced Jul 7, 2025

fix: Code Quality improvements to response record endpoint and added unit tests #22264

Merged

fix: Add new route to create team routing-form response #22347

Merged

Conversation

hariombalhara commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

How to connect a response with booking

Followup

Video Demo (if applicable):

Mandatory Tasks (DO NOT REMOVE)

Uh oh!

vercel bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara commented Jul 3, 2025

Uh oh!

delve-auditor bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

hariombalhara Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ThyMinimalDev Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThyMinimalDev Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hariombalhara Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hariombalhara Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jul 4, 2025

Graphite Automations

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hariombalhara commented Jul 3, 2025 •

edited

Loading

vercel bot commented Jul 3, 2025 •

edited

Loading

delve-auditor bot commented Jul 3, 2025 •

edited

Loading

github-actions bot commented Jul 3, 2025 •

edited

Loading

hariombalhara Jul 3, 2025 •

edited

Loading

socket-security bot commented Jul 4, 2025 •

edited

Loading