fix: Add missing lockefile from Jelly app by joeauyeung · Pull Request #13949 · calcom/cal.com

joeauyeung · 2024-03-01T18:06:36Z

What does this PR do?

Fixes # (issue)

Requirement/Documentation

If there is a requirement document, please, share it here.
If there is ab UI/UX design document, please, share it here.

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

github-actions · 2024-03-01T18:06:47Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

graphite-app · 2024-03-01T18:10:11Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (03/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-03-01T18:18:16Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-03-01T18:19:15Z

Current Playwright Test Results Summary

✅ 284 Passing - ⚠️ 26 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/01/2024 06:21:40pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c3dcba6

Started: 03/01/2024 06:18:13pm UTC

⚠️ Flakes

📄 apps/web/playwright/oauth-provider.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
OAuth Provider redirect not logged-in users to login page and after forward to authorization page Retry 1 • Initial Attempt	0% (0) 0 / 203 runs failed over last 7 days	0.49% (1) 1 / 203 run flaked over last 7 days

📄 apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

`null`	13 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes Retry 1 • Initial Attempt	-7.77% (-15) -15 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes Retry 1 • Initial Attempt	-6.74% (-13) -13 / 193 runs failed over last 7 days	7.77% (15) 15 / 193 runs flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes Retry 1 • Initial Attempt	-7.85% (-15) -15 / 191 runs failed over last 7 days	7.85% (15) 15 / 191 runs flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-3.66% (-7) -7 / 191 runs failed over last 7 days	7.85% (15) 15 / 191 runs flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-7.85% (-15) -15 / 191 runs failed over last 7 days	7.85% (15) 15 / 191 runs flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes Retry 1 • Initial Attempt	-4.92% (-9) -9 / 183 runs failed over last 7 days	8.20% (15) 15 / 183 runs flaked over last 7 days

📄 apps/web/playwright/impersonation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Users can impersonate App Admin can impersonate users with impersonation enabled Retry 1 • Initial Attempt	0% (0) 0 / 196 runs failed over last 7 days	8.67% (17) 17 / 196 runs flaked over last 7 days

📄 apps/web/playwright/payment-apps.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Payment app Should be able to edit stripe price, currency Retry 1 • Initial Attempt	1.95% (4) 4 / 205 runs failed over last 7 days	0.98% (2) 2 / 205 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address Retry 1 • Initial Attempt	3.43% (7) 7 / 204 runs failed over last 7 days	14.71% (30) 30 / 204 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

`null`	8 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	-0.48% (-1) -1 / 209 runs failed over last 7 days	50.24% (105) 105 / 209 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-95.24% (-100) -100 / 105 runs failed over last 7 days	96.19% (101) 101 / 105 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-98.04% (-100) -100 / 102 runs failed over last 7 days	98.04% (100) 100 / 102 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-97.06% (-99) -99 / 102 runs failed over last 7 days	98.04% (100) 100 / 102 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-99.01% (-100) -100 / 101 runs failed over last 7 days	99.01% (100) 100 / 101 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-99.01% (-100) -100 / 101 runs failed over last 7 days	99.01% (100) 100 / 101 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-99.01% (-100) -100 / 101 runs failed over last 7 days	99.01% (100) 100 / 101 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-99.01% (-100) -100 / 101 runs failed over last 7 days	99.01% (100) 100 / 101 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 208 runs failed over last 7 days	44.23% (92) 92 / 208 runs flaked over last 7 days

View Detailed Build Results

zomars · 2024-03-01T19:45:01Z

Sorry @baileypumfleet @joeauyeung but this PR has way more changes than expected. Something's wrong with it. Will update on main directly.

Add missing lock file

c3dcba6

graphite-app bot requested review from a team March 1, 2024 18:06

joeauyeung requested review from zomars and removed request for a team March 1, 2024 18:06

keithwillcode added consumer core area: core, team members only labels Mar 1, 2024

vercel bot deployed to Preview – api March 1, 2024 18:09 View deployment

vercel bot deployed to Preview – dev March 1, 2024 18:18 View deployment

joeauyeung mentioned this pull request Mar 1, 2024

feat: jelly integration #13929

Merged

1 task

pumfleet approved these changes Mar 1, 2024

View reviewed changes

pumfleet merged commit 23d22ee into main Mar 1, 2024

pumfleet deleted the add-jelly-lock-file branch March 1, 2024 19:28

zomars pushed a commit that referenced this pull request Mar 4, 2024

Add missing lock file (#13949)

89c27cf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add missing lockefile from Jelly app#13949

fix: Add missing lockefile from Jelly app#13949
pumfleet merged 1 commit intomainfrom
add-jelly-lock-file

joeauyeung commented Mar 1, 2024

Uh oh!

github-actions bot commented Mar 1, 2024

Uh oh!

graphite-app bot commented Mar 1, 2024

Uh oh!

github-actions bot commented Mar 1, 2024

Uh oh!

deploysentinel bot commented Mar 1, 2024 •

edited

Loading

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

zomars commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joeauyeung commented Mar 1, 2024

What does this PR do?

Requirement/Documentation

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

github-actions bot commented Mar 1, 2024

Uh oh!

graphite-app bot commented Mar 1, 2024

Graphite Automations

Uh oh!

github-actions bot commented Mar 1, 2024

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

zomars commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deploysentinel bot commented Mar 1, 2024 •

edited

Loading