test: verify embed helpers by wesleymatosdev · Pull Request #11318 · calcom/cal.com

wesleymatosdev · 2023-09-12T20:40:41Z

test: add test cases to window.getEmbedNamespace
test: add test cases when window.name doesn't have cal-embed=
test: add test case to getembedTheme returning the theme from embedStore
test: add test to getEmbedTheme returning the theme from query params

What does this PR do?

Adding tests to getEmbedTheme, getEmbedNamespace and isEmbed

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

It should be run via yarn e2e:embed. Probably the automated pipelines will run these new tests.
None of the tests added on this PR should break.

…Store

CLAassistant · 2023-09-12T20:40:48Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

vercel · 2023-09-12T20:40:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 14, 2023 7:05am

vercel · 2023-09-12T20:40:49Z

@ologbonowiwi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2023-09-12T20:40:56Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-09-12T20:48:59Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

hariombalhara · 2023-09-14T05:35:04Z

packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts


 import { test } from "@calcom/web/playwright/lib/fixtures";

+import "../../src/types.d";


now window.isEmbed type definition would be available.

hariombalhara · 2023-09-14T05:35:37Z

packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts


-  test("should change to embed when window.name is changed to cal-embed=", async ({ page }) => {
-    await page.goto("http://localhost:3000/free/30min");
+  test.describe("isEmbed, getEmbedNamespace, getEmbedTheme testing", () => {


Clubbed the tests under one describe.

hariombalhara · 2023-09-14T05:36:10Z

packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts

+      page,
+    }) => {
+      const queryParamTheme = "dark";
+      await page.evaluate(() => {


We can set window.name before going to the URL and then load the URL. It avoids an unnecessary page load saving time per test.

hariombalhara · 2023-09-14T05:37:17Z

packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts

-  test("should change to embed when window.name is changed to cal-embed=", async ({ page }) => {
-    await page.goto("http://localhost:3000/free/30min");
+  test.describe("isEmbed, getEmbedNamespace, getEmbedTheme testing", () => {
+    test("when `window.name` is set to 'cal-embed=' and `theme` is supplied as a query param", async ({


Also clubbed the different test sections for isEmbed and getEmbedNamespace together so that we can test both on a single page visit. This is to again save time as we really want to not increase time taken by our E2E tests significantly

hariombalhara · 2023-09-14T05:38:04Z

packages/embeds/embed-core/src/types.d.ts

Moved global type augmentation here so that they can be shared with others.

…ngs for embed functions on window

hariombalhara

Thanks @ologbonowiwi 🙏 LGTM!!

shivamklr

Tested, lgtm.

* test: add test cases to `window.getEmbedNamespace` * test: add test cases when window.name doesn't have cal-embed= * test: add test case to `getembedTheme` returning the theme from embedStore * test: add test to `getEmbedTheme` returning the theme from query params * Small refactor to reduce the time taken by tests and fix missing typings for embed functions on window * Fix weird test failure * Fix type import error caught by api.test.test --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>

wesleymatosdev added 4 commits September 12, 2023 17:25

test: add test cases to window.getEmbedNamespace

6304724

test: add test cases when window.name doesn't have cal-embed=

24ea5e7

test: add test case to getembedTheme returning the theme from embed…

b1db837

…Store

test: add test to getEmbedTheme returning the theme from query params

9b35aa4

algora-pbc bot mentioned this pull request Sep 12, 2023

[CAL-1753] Embed: Update e2e tests to verify that methods like getEmbedNamespace, getEmbedTheme, isEmbed work correctly. #9086

Closed

algora-pbc bot added the 🙋 Bounty claim label Sep 12, 2023

github-actions bot added automated-tests area: unit tests, e2e tests, playwright embed area: embed, widget, react embed High priority Created by Linear-GitHub Sync 💎 Bounty A bounty on Algora.io labels Sep 12, 2023

vercel bot deployed to Preview – ui September 12, 2023 20:44 View deployment

hariombalhara reviewed Sep 14, 2023

View reviewed changes

hariombalhara force-pushed the test/verify-embed-helpers branch from 6bf85b5 to f8b0b45 Compare September 14, 2023 05:35

hariombalhara reviewed Sep 14, 2023

View reviewed changes

Small refactor to reduce the time taken by tests and fix missing typi…

a5fce79

…ngs for embed functions on window

hariombalhara force-pushed the test/verify-embed-helpers branch from f8b0b45 to a5fce79 Compare September 14, 2023 05:41

vercel bot deployed to Preview – ui September 14, 2023 05:45 View deployment

hariombalhara previously approved these changes Sep 14, 2023

View reviewed changes

hariombalhara added the automerge label Sep 14, 2023

hariombalhara dismissed their stale review via 40045cd September 14, 2023 06:02

vercel bot deployed to Preview – ui September 14, 2023 06:06 View deployment

Fix weird test failure

3fd3085

hariombalhara force-pushed the test/verify-embed-helpers branch from 40045cd to 3fd3085 Compare September 14, 2023 06:07

vercel bot deployed to Preview – ui September 14, 2023 06:12 View deployment

hariombalhara previously approved these changes Sep 14, 2023

View reviewed changes

hariombalhara dismissed their stale review via 687459a September 14, 2023 06:33

vercel bot deployed to Preview – ui September 14, 2023 06:37 View deployment

Fix type import error caught by api.test.test

ba705b7

hariombalhara force-pushed the test/verify-embed-helpers branch from 687459a to ba705b7 Compare September 14, 2023 07:01

vercel bot deployed to Preview – ui September 14, 2023 07:05 View deployment

hariombalhara approved these changes Sep 14, 2023

View reviewed changes

kodiakhq bot merged commit dfde171 into calcom:main Sep 14, 2023

shivamklr reviewed Sep 14, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: verify embed helpers#11318

test: verify embed helpers#11318
kodiakhq[bot] merged 7 commits intocalcom:mainfrom
wesleymatosdev:test/verify-embed-helpers

wesleymatosdev commented Sep 12, 2023 •

edited

Loading

Uh oh!

CLAassistant commented Sep 12, 2023

Uh oh!

vercel bot commented Sep 12, 2023 •

edited

Loading

Uh oh!

vercel bot commented Sep 12, 2023

Uh oh!

github-actions bot commented Sep 12, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Sep 12, 2023 •

edited

Loading

Uh oh!

hariombalhara Sep 14, 2023

Uh oh!

hariombalhara Sep 14, 2023

Uh oh!

hariombalhara Sep 14, 2023

Uh oh!

hariombalhara Sep 14, 2023

Uh oh!

hariombalhara Sep 14, 2023

Uh oh!

hariombalhara left a comment

Uh oh!

shivamklr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		import { test } from "@calcom/web/playwright/lib/fixtures";

		import "../../src/types.d";

Conversation

wesleymatosdev commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Uh oh!

CLAassistant commented Sep 12, 2023

Uh oh!

vercel bot commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 12, 2023

Uh oh!

github-actions bot commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

hariombalhara Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

shivamklr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wesleymatosdev commented Sep 12, 2023 •

edited

Loading

vercel bot commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Sep 12, 2023 •

edited

Loading