fix: other reported issues by leog · Pull Request #11015 · calcom/cal.com

leog · 2023-08-29T20:39:44Z

What does this PR do?

A bunch of small fixes tackling reported issues in the meet.cal.com thread

1. Weird margin top in avatar

2. Pending users are shown on booking page / Avatar images and naming issues

3. Toast alignment and removing unneeded titles

4. Empty state for teams without event types

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

1. See the user avatar when logging in in the sidebar and notice no weird margin on top
1. Create a team within an organization and invite users to it. Then create an event type for that team and assign pending/non-pending members to it. In the booking page you should just be seeing non-pending users in the event description, also with their username when they don't have set up a name
1. Generate certain action within the app and see a long toast message being shown correctly as in the above screenshot
1. Create an org team without event types and see the above empty state

vercel · 2023-08-29T20:39:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 8:38pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 8:38pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 8:38pm
ui	❌ Failed (Inspect)			Aug 30, 2023 8:38pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Aug 30, 2023 8:38pm
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 30, 2023 8:38pm

github-actions · 2023-08-29T20:39:56Z

Thank you for following the naming conventions! 🙏

leog · 2023-08-29T20:40:23Z

apps/web/components/eventtype/EventTeamTab.tsx

  value: `${id || ""}`,
  label: `${name || email || ""}${!username ? ` (${pendingString})` : ""}`,
-  avatar: `${WEBAPP_URL}/${username}/avatar.png`,
+  avatar,


Relying on the avatar that comes already calculated by the endpoint

leog · 2023-08-29T20:40:53Z

apps/web/pages/event-types/[type]/index.tsx

-        }),
-        "success"
-      );
+      showToast(t("event_type_updated_successfully"), "success");


We now don't show the name of the updated event type as suggested by designer

leog · 2023-08-29T20:41:14Z

apps/web/pages/event-types/index.tsx

+    </>
+  );
+};
+


The empty screen for a team without event types

leog · 2023-08-29T20:41:46Z

packages/features/bookings/Booker/components/DatePicker.tsx

@@ -1,6 +1,5 @@
 import { shallow } from "zustand/shallow";

-import type { Dayjs } from "@calcom/dayjs";


Autocorrection

leog · 2023-08-29T20:41:54Z

packages/features/bookings/Booker/store.ts

    // Setting month make sure small calendar in fullscreen layouts also updates.
    // If selectedDate is null, prevents setting month to Invalid-Date
-    if (selectedDate && newSelection.month() !== currentSelection.month() ) {
+    if (selectedDate && newSelection.month() !== currentSelection.month()) {


Autocorrection

leog · 2023-08-29T20:42:11Z

packages/features/bookings/components/event-meta/Members.tsx


  const avatars: Avatar[] = shownUsers.map((user) => ({
-    title: `${user.name}`,
+    title: `${user.name || user.username}`,


Showing username when no name is available to avoid "null"

leog · 2023-08-29T20:42:16Z

packages/features/bookings/components/event-meta/Members.tsx

  // Add profile later since we don't want to force creating an avatar for this if it doesn't exist.
  avatars.unshift({
-    title: `${profile.name}`,
+    title: `${profile.name || profile.username}`,


Showing username when no name is available to avoid "null"

leog · 2023-08-29T20:42:36Z

packages/features/ee/organizations/components/AboutOrganizationForm.tsx

                  <Avatar
                    alt=""
                    fallback={<Plus className="text-subtle h-6 w-6" />}
-                    asChild


This was causing issues to show the fallback image in this context

leog · 2023-08-29T20:42:42Z

packages/features/embed/Embed.tsx

 import { components } from "react-select";
 import { shallow } from "zustand/shallow";

-import type { Dayjs } from "@calcom/dayjs";


Autocorrection

leog · 2023-08-29T20:43:10Z

packages/features/eventtypes/components/ChildrenEventTypeSelect.tsx

-                imageSrc={`${CAL_URL}/${children.owner.username}/avatar.png`}
+                imageSrc={`${orgBranding ? getOrgFullDomain(orgBranding.slug) : CAL_URL}/${
+                  children.owner.username
+                }/avatar.png`}


Showing the correct avatar when on an org context

leog · 2023-08-29T20:43:22Z

packages/features/eventtypes/components/CreateEventTypeDialog.tsx

    onSuccess: async ({ eventType }) => {
      await router.replace("/event-types/" + eventType.id);
-      showToast(t("event_type_created_successfully", { eventTypeTitle: eventType.title }), "success");
+      showToast(t("event_type_created_successfully"), "success");


We now don't show the name of the created event type as suggested by designer

leog · 2023-08-29T20:43:30Z

packages/features/eventtypes/components/DuplicateDialog.tsx

    onSuccess: async ({ eventType }) => {
      await router.replace("/event-types/" + eventType.id);
-      showToast(t("event_type_created_successfully", { eventTypeTitle: eventType.title }), "success");
+      showToast(t("event_type_created_successfully"), "success");


We now don't show the name of the created event type as suggested by designer

leog · 2023-08-29T20:43:58Z

packages/features/eventtypes/lib/getPublicEvent.ts

  const { team, hosts, owner } = event;
  if (team) {
-    return (hosts || []).map(mapHostsToUsers);
+    return (hosts || []).filter((host) => host.user.username).map(mapHostsToUsers);


Not showing pending users (hence, no username)

leog · 2023-08-29T20:44:37Z

packages/lib/getEventTypeById.ts

+            select: {
+              slug: true,
+            },
+          },


Having the parent team (org) slug to calculate avatar URLs in an org context

leog · 2023-08-29T20:45:46Z

packages/prisma/zod-utils.ts

 export type ZVerifyCodeInputSchema = z.infer<typeof ZVerifyCodeInputSchema>;

 export const coerceToDate = z.coerce.date();
-


Autocorrection

leog · 2023-08-29T20:46:03Z

packages/trpc/server/routers/loggedInViewer/me.handler.ts

-    avatar: `${WEBAPP_URL}/${user.username}/avatar.png`,
+    avatar: `${user.organization?.slug ? getOrgFullDomain(user.organization.slug) : WEBAPP_URL}/${
+      user.username
+    }/avatar.png`,


Calculating the avatar URL in an org context if applies

leog · 2023-08-29T20:46:37Z

packages/trpc/server/routers/viewer/eventTypes/getByViewer.handler.ts

  return {
    // don't display event teams without event types,
-    eventTypeGroups: eventTypeGroups.filter((groupBy) => !!groupBy.eventTypes?.length),
+    eventTypeGroups: eventTypeGroups.filter((groupBy) => groupBy.parentId || !!groupBy.eventTypes?.length),


This is to show teams without event types in an org context

deploysentinel · 2023-08-30T14:41:51Z

Current Playwright Test Results Summary

✅ 122 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/30/2023 08:26:28pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f35a780

Started: 08/30/2023 08:23:54pm UTC

⚠️ Flakes

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking Retry 1 • Initial Attempt	0.43% (1) 1 / 230 run failed over last 7 days	7.39% (17) 17 / 230 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event Retry 1 • Initial Attempt	1.18% (3) 3 / 254 runs failed over last 7 days	30.31% (77) 77 / 254 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user can duplicate an existing event type Retry 1 • Initial Attempt	0.36% (1) 1 / 276 run failed over last 7 days	2.54% (7) 7 / 276 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	6.16% (17) 17 / 276 runs failed over last 7 days	93.48% (258) 258 / 276 runs flaked over last 7 days

View Detailed Build Results

alannnc

Code looks good!

zomars

* fix: weird margin top in avatar * fix: pending users are shown on booking page * fix: avatar and naming issues * fix: toast alignment and removing unneeded titles * missing changes from toast improvements * feat: empty state for teams without event types * Removing console.log

* Add loading data and banner * [WIP] hasEditPerms middleware * fix: type error in booker (#11011) * New Crowdin translations by Github Action * refactor: removed redundant test (#10785) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> * feat: 2fa backup codes (#10600) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Delete add-PRs-to-project-reviewing-PRs.yml (#11008) Co-authored-by: alannnc <alannnc@gmail.com> * New Crowdin translations by Github Action * fix: multiple duration when booking (#11032) * fix: other reported issues (#11015) * fix: weird margin top in avatar * fix: pending users are shown on booking page * fix: avatar and naming issues * fix: toast alignment and removing unneeded titles * missing changes from toast improvements * feat: empty state for teams without event types * Removing console.log * feat: cal ai (#10992) Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> * New Crowdin translations by Github Action * fix: meeting ended trigger for webhooks and zapier sometimes not working (#10946) Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * feat: team admin: see connected apps of team members (#11036) * added feature:team admin can see connected apps of members * fixed the type error * Update packages/lib/server/queries/teams/index.ts * Minor fixes --------- Co-authored-by: alannnc <alannnc@gmail.com> * fix: lower case slugs in teams (#11026) * fix: lower case slugs in teams Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: use slugify Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * refactor: improvements on german translation (#10898) * fix: fix-tablet-menu-not-centered-sidebar (#11020) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * chore: add Popover in storybook (#11021) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: Set mobile availability (#11027) * chore: add ColorPicker in storybook (CALCOM-10760) (#10866) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: adds next cold start profiler (#11014) * Handle disabling of ORGANIZATIONS_ENABLED flag (#11041) * New Crowdin translations by Github Action * styles:dark mode color fix (#11004) * chore: sheet darkmode and improve responsive (#11047) * fix: handle collective multiple host on destinationCalendar (#10967) * fix: include app data and credentials from DB (#11048) * include app data and credentials from DB * Improve performance * fix: Error when running storybook (#11037) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: broken company profile link on team booking page (#10978) * chore: add ErrorBoundary in storybook (CALCOM-10760) (#10872) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: sorting for workflow and routing forms (#10780) Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * resolve zod versions across child packages (#11052) * fix: List storybook file is empty (fix-list) (#10965) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: admin org list without members (#11051) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add ToggleGroup in storybook (#10802) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * fix: add metadata to stripe payment intent (#11053) * fix: Logo storybook file with invalid icons (fix-logo) (#11018) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Add controls for Select Field storybook file (#10936) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Fix tooltip control on ButtonPlayground storybook file (fix-ButtonTooltip) (#10937) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: email embed – remove collapsible and permanently show times (#10996) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Mehul <mehulzr@gmail.com> * chore: add Timezone Select in storybook (CALCOM-10760) (#10966) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add Switch in storybook (CALCOM-10760) (#10804) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Sync packages * fix: zod utils due to upgrade * easy fix (#11054) * fix sub quantity update stripe (#11057) * v3.2.7 * Revert "feat: adds next cold start profiler (#11014)" (#11072) This reverts commit 05631d0. * fix: Fixes username invite issue (#10998) * Fixes username invite issue * Ensure we only suggest email invites in org members --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * Fix sheet layout * WIP permissions when userschedule doesnt match * WIP get handler weird behaviour * Update toast * add disabled - handle membership overlap * Handle permissions + perf improvments * use input uid * Remove Console.log * Clean up * Revert changes accidental * Fix merge artifacts * Remove dead code * Remove code after return * Update read permission check * Revert avatar changes as fixed elsewhere * Handle if user has not completed onboarding * Disable button * Update packages/lib/hasEditPermissionForUser.ts * Correct Error throwing * Update packages/features/timezone-buddy/components/AvailabilityEditSheet.tsx * Fix type erro * Add i18n * Improve Spacing * Update yarn.lock --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: DexterStorey <36115192+DexterStorey@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Monto <138862352+montocoder@users.noreply.github.com> Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Abhijeet Singh <asingh9829@gmail.com> Co-authored-by: Kamil B. Demirci <kamil.demirci@indyaner.ch> Co-authored-by: Denzil Samuel <71846487+samueldenzil@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Sahil Padvi <71093044+Sahil25061999@users.noreply.github.com> Co-authored-by: Patel Divyesh <pateldivyesh1323@gmail.com> Co-authored-by: neo773 <62795688+neo773@users.noreply.github.com> Co-authored-by: Mehul <mehulzr@gmail.com>

* Add loading data and banner * [WIP] hasEditPerms middleware * fix: type error in booker (calcom#11011) * New Crowdin translations by Github Action * refactor: removed redundant test (calcom#10785) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> * feat: 2fa backup codes (calcom#10600) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Delete add-PRs-to-project-reviewing-PRs.yml (calcom#11008) Co-authored-by: alannnc <alannnc@gmail.com> * New Crowdin translations by Github Action * fix: multiple duration when booking (calcom#11032) * fix: other reported issues (calcom#11015) * fix: weird margin top in avatar * fix: pending users are shown on booking page * fix: avatar and naming issues * fix: toast alignment and removing unneeded titles * missing changes from toast improvements * feat: empty state for teams without event types * Removing console.log * feat: cal ai (calcom#10992) Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> * New Crowdin translations by Github Action * fix: meeting ended trigger for webhooks and zapier sometimes not working (calcom#10946) Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * feat: team admin: see connected apps of team members (calcom#11036) * added feature:team admin can see connected apps of members * fixed the type error * Update packages/lib/server/queries/teams/index.ts * Minor fixes --------- Co-authored-by: alannnc <alannnc@gmail.com> * fix: lower case slugs in teams (calcom#11026) * fix: lower case slugs in teams Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: use slugify Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * refactor: improvements on german translation (calcom#10898) * fix: fix-tablet-menu-not-centered-sidebar (calcom#11020) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * chore: add Popover in storybook (calcom#11021) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: Set mobile availability (calcom#11027) * chore: add ColorPicker in storybook (CALCOM-10760) (calcom#10866) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: adds next cold start profiler (calcom#11014) * Handle disabling of ORGANIZATIONS_ENABLED flag (calcom#11041) * New Crowdin translations by Github Action * styles:dark mode color fix (calcom#11004) * chore: sheet darkmode and improve responsive (calcom#11047) * fix: handle collective multiple host on destinationCalendar (calcom#10967) * fix: include app data and credentials from DB (calcom#11048) * include app data and credentials from DB * Improve performance * fix: Error when running storybook (calcom#11037) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: broken company profile link on team booking page (calcom#10978) * chore: add ErrorBoundary in storybook (CALCOM-10760) (calcom#10872) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: sorting for workflow and routing forms (calcom#10780) Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * resolve zod versions across child packages (calcom#11052) * fix: List storybook file is empty (fix-list) (calcom#10965) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: admin org list without members (calcom#11051) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add ToggleGroup in storybook (calcom#10802) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * fix: add metadata to stripe payment intent (calcom#11053) * fix: Logo storybook file with invalid icons (fix-logo) (calcom#11018) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Add controls for Select Field storybook file (calcom#10936) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Fix tooltip control on ButtonPlayground storybook file (fix-ButtonTooltip) (calcom#10937) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: email embed – remove collapsible and permanently show times (calcom#10996) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Mehul <mehulzr@gmail.com> * chore: add Timezone Select in storybook (CALCOM-10760) (calcom#10966) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add Switch in storybook (CALCOM-10760) (calcom#10804) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Sync packages * fix: zod utils due to upgrade * easy fix (calcom#11054) * fix sub quantity update stripe (calcom#11057) * v3.2.7 * Revert "feat: adds next cold start profiler (calcom#11014)" (calcom#11072) This reverts commit 05631d0. * fix: Fixes username invite issue (calcom#10998) * Fixes username invite issue * Ensure we only suggest email invites in org members --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * Fix sheet layout * WIP permissions when userschedule doesnt match * WIP get handler weird behaviour * Update toast * add disabled - handle membership overlap * Handle permissions + perf improvments * use input uid * Remove Console.log * Clean up * Revert changes accidental * Fix merge artifacts * Remove dead code * Remove code after return * Update read permission check * Revert avatar changes as fixed elsewhere * Handle if user has not completed onboarding * Disable button * Update packages/lib/hasEditPermissionForUser.ts * Correct Error throwing * Update packages/features/timezone-buddy/components/AvailabilityEditSheet.tsx * Fix type erro * Add i18n * Improve Spacing * Update yarn.lock --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: DexterStorey <36115192+DexterStorey@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Monto <138862352+montocoder@users.noreply.github.com> Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Abhijeet Singh <asingh9829@gmail.com> Co-authored-by: Kamil B. Demirci <kamil.demirci@indyaner.ch> Co-authored-by: Denzil Samuel <71846487+samueldenzil@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Sahil Padvi <71093044+Sahil25061999@users.noreply.github.com> Co-authored-by: Patel Divyesh <pateldivyesh1323@gmail.com> Co-authored-by: neo773 <62795688+neo773@users.noreply.github.com> Co-authored-by: Mehul <mehulzr@gmail.com>

leog added 7 commits August 28, 2023 11:33

fix: weird margin top in avatar

f7662c9

fix: pending users are shown on booking page

96807c9

fix: avatar and naming issues

cc7f7ef

fix: toast alignment and removing unneeded titles

74ae1c2

missing changes from toast improvements

8666825

feat: empty state for teams without event types

6ec12f1

Merge branch 'main' into fix/other-org-fixes

bf6f6d8

leog requested a review from a team August 29, 2023 20:39

leog self-assigned this Aug 29, 2023

zomars added the core area: core, team members only label Aug 29, 2023

leog commented Aug 29, 2023

View reviewed changes

Removing console.log

81607d8

leog commented Aug 29, 2023

View reviewed changes

vercel bot deployed to Preview – cal-demo August 29, 2023 21:23 View deployment

vercel bot deployed to Preview – api August 29, 2023 21:24 View deployment

Merge branch 'main' into fix/other-org-fixes

cc935c4

vercel bot had a problem deploying to Preview – ui August 30, 2023 14:30 Failure

vercel bot deployed to Preview – cal-demo August 30, 2023 14:32 View deployment

vercel bot deployed to Preview – api August 30, 2023 14:32 View deployment

vercel bot deployed to Preview – dev August 30, 2023 14:33 View deployment

alannnc previously approved these changes Aug 30, 2023

View reviewed changes

Merge branch 'main' into fix/other-org-fixes

e688977

leog enabled auto-merge (squash) August 30, 2023 20:04

zomars previously approved these changes Aug 30, 2023

View reviewed changes

Fixing e2e

f35a780

leog dismissed stale reviews from zomars and alannnc via f35a780 August 30, 2023 20:17

vercel bot had a problem deploying to Preview – ui August 30, 2023 20:21 Failure

vercel bot deployed to Preview – api August 30, 2023 20:22 View deployment

vercel bot deployed to Preview – cal-demo August 30, 2023 20:23 View deployment

vercel bot deployed to Preview – dev August 30, 2023 20:23 View deployment

alannnc approved these changes Aug 30, 2023

View reviewed changes

leog merged commit 356117f into main Aug 30, 2023

leog deleted the fix/other-org-fixes branch August 30, 2023 20:42

		@@ -1,6 +1,5 @@
		import { shallow } from "zustand/shallow";

		import type { Dayjs } from "@calcom/dayjs";

		export type ZVerifyCodeInputSchema = z.infer<typeof ZVerifyCodeInputSchema>;

		export const coerceToDate = z.coerce.date();

Conversation

leog commented Aug 29, 2023

What does this PR do?

1. Weird margin top in avatar

2. Pending users are shown on booking page / Avatar images and naming issues

3. Toast alignment and removing unneeded titles

4. Empty state for teams without event types

Type of change

How should this be tested?

Uh oh!

vercel bot commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deploysentinel bot commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

alannnc left a comment

Choose a reason for hiding this comment

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Aug 29, 2023 •

edited

Loading

deploysentinel bot commented Aug 30, 2023 •

edited

Loading