test: Create unit tests for react components in packages/ui/components/layout#10458
Merged
hariombalhara merged 2 commits intomainfrom Jul 31, 2023
Merged
test: Create unit tests for react components in packages/ui/components/layout#10458hariombalhara merged 2 commits intomainfrom
hariombalhara merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 47 of 225 screens tested: view and approve differences detected. Last updated for commit a909f4e. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 106 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/31/2023 06:24:56am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a909f4e Started: 07/31/2023 06:22:40am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
1.15% (3)3 / 262 runsfailed over last 7 days |
33.97% (89)89 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED can submit a form and get a submission event
Retry 1 • Initial Attempt |
1.88% (5)5 / 266 runsfailed over last 7 days |
18.80% (50)50 / 266 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
0.40% (1)1 / 247 runfailed over last 7 days |
95.14% (235)235 / 247 runsflaked over last 7 days |
hariombalhara
approved these changes
Jul 31, 2023
| describe("Tests for ShellSubHeading Component", () => { | ||
| test("Should render correctly the component with title and subtitle if the prop was passed", () => { | ||
| const { getByText, queryByText, rerender } = render( | ||
| <ShellSubHeading title={titleText} subtitle={subtitleText} /> |
Member
There was a problem hiding this comment.
We should test className as well.
sean-brydon
pushed a commit
that referenced
this pull request
Jul 31, 2023
…s/layout (#10458) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo
Run