test: Create unit tests for react components in packages/ui/components/form/checkbox#10409
Merged
keithwillcode merged 1 commit intomainfrom Jul 27, 2023
Merged
test: Create unit tests for react components in packages/ui/components/form/checkbox#10409keithwillcode merged 1 commit intomainfrom
keithwillcode merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 49 of 171 screens tested: view and approve differences detected. Last updated for commit 0b897f0. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 105 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/26/2023 05:56:05pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 0b897f0 Started: 07/26/2023 05:53:17pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 74 runsfailed over last 7 days |
6.76% (5)5 / 74 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
1.99% (6)6 / 302 runsfailed over last 7 days |
39.40% (119)119 / 302 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.35% (3)3 / 223 runsfailed over last 7 days |
98.21% (219)219 / 223 runsflaked over last 7 days |
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 222 runsfailed over last 7 days |
8.11% (18)18 / 222 runsflaked over last 7 days |
28 tasks
sean-brydon
approved these changes
Jul 27, 2023
Member
sean-brydon
left a comment
There was a problem hiding this comment.
Amazing thank you. I wonder if in the future we should swap this out for the Radix Checkbox defined in the same file.
sean-brydon
pushed a commit
that referenced
this pull request
Jul 31, 2023
…s/form/checkbox (#10409) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO
Run