test: Create unit tests for react components in packages/ui/components/button by gitstart-calcom · Pull Request #10045 · calcom/cal.com

gitstart-calcom · 2023-07-10T17:53:54Z

DEMO

Run

yarn test button

vercel · 2023-07-10T17:53:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 3:06pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 3:06pm
cal-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 3:06pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 3:06pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Mar 19, 2024 3:06pm
dev	⬜️ Ignored (Inspect)	Visit Preview	Mar 19, 2024 3:06pm
qa	⬜️ Ignored (Inspect)		Mar 19, 2024 3:06pm

github-actions · 2023-07-10T17:54:06Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-07-10T18:01:51Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-07-10T18:03:00Z

Current Playwright Test Results Summary

✅ 74 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/24/2023 09:23:08pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: df689ef

Started: 07/24/2023 09:21:23pm UTC

⚠️ Flakes

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	9.97% (31) 31 / 311 runs failed over last 7 days	36.01% (112) 112 / 311 runs flaked over last 7 days

View Detailed Build Results

ericrommel

Hey @gitstart-calcom, sorry, but unit testing for ui components from a third-party library doesn't make any sense. Can you elaborate on how valuable for us to test them? unit tests are linked to actions on our behaviours, not from external components. We can achieve UI behavioural expectations from the high-level testing part, like UI Testing, Acceptance testing and others that can be even automated. What do you think to discuss about it (if needed)?

gitstart-calcom · 2023-07-12T00:47:36Z

Hi @ericrommel, how are you? 😄
It was discussed in our Slack group about creating these tests and we were allowed to create these PRs, unit tests for UI components offer valuable benefits, even if they come from a third-party library. here are some points that you should consider:

They allow isolated testing of internal logic and behavior specific to the components.
Unit tests provide a faster feedback loop, helping identify and address component-specific issues promptly.
They contribute to overall test coverage and enhance confidence in the codebase's stability and reliability.
Unit tests for UI components complement high-level testing approaches, focusing on internal behaviors.

In summary, incorporating unit tests for UI components in the calcom brings advantages in terms of isolated testing, faster feedback, improved test coverage, and enhanced confidence. What do you think?

alwaysmeticulous · 2023-07-12T00:56:37Z

🤖 Meticulous spotted visual differences in 36 of 161 screens tested: view and approve differences detected.

_{Last updated for commit df689ef. This comment will update as new commits are pushed.}

sean-brydon

Great work! Happy with this!

Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>

Create RTL tests for Button component

c521ae3

zomars added the core area: core, team members only label Jul 10, 2023

vercel bot had a problem deploying to Preview – ui July 10, 2023 17:57 Failure

vercel bot deployed to Preview – api July 10, 2023 17:59 View deployment

vercel bot deployed to Preview – cal July 10, 2023 18:01 View deployment

gitstart-calcom marked this pull request as ready for review July 10, 2023 18:53

gitstart-calcom requested review from PeerRich, alannnc, hariombalhara, keithwillcode, sean-brydon and zomars and removed request for hariombalhara July 10, 2023 19:36

PeerRich added the Low priority Created by Linear-GitHub Sync label Jul 10, 2023

ericrommel suggested changes Jul 11, 2023

View reviewed changes

gitstart-calcom requested review from ericrommel July 12, 2023 00:48

Merge branch 'main' into CALCOM-615

37a0ac4

vercel bot deployed to Preview – ui July 12, 2023 00:51 View deployment

vercel bot deployed to Preview – api July 12, 2023 00:55 View deployment

vercel bot deployed to Preview – cal July 12, 2023 00:56 View deployment

vercel bot deployed to Preview – cal-staging July 12, 2023 00:59 View deployment

Merge branch 'main' into CALCOM-615

dca9065

vercel bot deployed to Preview – ui July 18, 2023 02:52 View deployment

vercel bot deployed to Preview – cal-demo July 18, 2023 02:54 View deployment

vercel bot deployed to Preview – api July 18, 2023 02:54 View deployment

vercel bot deployed to Preview – cal-staging July 18, 2023 02:55 View deployment

vercel bot deployed to Preview – cal July 18, 2023 02:56 View deployment

gitstart-calcom added 2 commits July 19, 2023 21:50

Merge branch 'main' into CALCOM-615

a8d2915

Update package.json

05d7e3d

vercel bot deployed to Preview – ui July 19, 2023 20:58 View deployment

vercel bot deployed to Preview – api July 19, 2023 21:01 View deployment

vercel bot deployed to Preview – cal-demo July 19, 2023 21:03 View deployment

vercel bot deployed to Preview – dev July 19, 2023 21:03 View deployment

gitstart-calcom changed the title ~~test: Create unit tests for react components in packages/ui/components/button (CALCOM-615)~~ test: Create unit tests for react components in packages/ui/components/button Jul 20, 2023

keithwillcode added the automated-tests area: unit tests, e2e tests, playwright label Jul 21, 2023

Merge branch 'main' into CALCOM-615

df689ef

vercel bot deployed to Preview – ui July 24, 2023 21:16 View deployment

vercel bot deployed to Preview – api July 24, 2023 21:18 View deployment

vercel bot deployed to Preview – cal-demo July 24, 2023 21:18 View deployment

vercel bot deployed to Preview – dev July 24, 2023 21:22 View deployment

gitstart-calcom mentioned this pull request Jul 26, 2023

Create unit tests for components #10406

Closed

28 tasks

sean-brydon approved these changes Jul 27, 2023

View reviewed changes

keithwillcode merged commit a1e6e8f into main Jul 27, 2023

keithwillcode deleted the CALCOM-615 branch July 27, 2023 13:47

keithwillcode added this to the v3.2 milestone Jul 27, 2023

sean-brydon pushed a commit that referenced this pull request Jul 31, 2023

Update package.json (#10045)

7131d9f

Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Create unit tests for react components in packages/ui/components/button#10045

test: Create unit tests for react components in packages/ui/components/button#10045
keithwillcode merged 6 commits intomainfrom
CALCOM-615

gitstart-calcom commented Jul 10, 2023 •

edited

Loading

Uh oh!

vercel bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

deploysentinel bot commented Jul 10, 2023 •

edited

Loading

Test Case Results

Uh oh!

ericrommel left a comment

Uh oh!

gitstart-calcom commented Jul 12, 2023

Uh oh!

alwaysmeticulous bot commented Jul 12, 2023 •

edited

Loading

Uh oh!

sean-brydon left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

gitstart-calcom commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DEMO

Uh oh!

vercel bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Uh oh!

ericrommel left a comment

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom commented Jul 12, 2023

Uh oh!

alwaysmeticulous bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sean-brydon left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gitstart-calcom commented Jul 10, 2023 •

edited

Loading

vercel bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

deploysentinel bot commented Jul 10, 2023 •

edited

Loading

alwaysmeticulous bot commented Jul 12, 2023 •

edited

Loading