test: Create unit tests for react components in packages/ui/components/credits by gitstart-calcom · Pull Request #10044 · calcom/cal.com

gitstart-calcom · 2023-07-10T17:50:30Z

DEMO

Run

yarn test credits

vercel · 2023-07-10T17:50:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2023 9:03pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2023 9:03pm
cal-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2023 9:03pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2023 9:03pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2023 9:03pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jul 19, 2023 9:03pm
qa	⬜️ Ignored (Inspect)			Jul 19, 2023 9:03pm

github-actions · 2023-07-10T17:50:42Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-07-10T17:58:37Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-07-10T18:00:42Z

Current Playwright Test Results Summary

✅ 71 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/19/2023 09:01:03pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c03fc2e

Started: 07/19/2023 08:58:36pm UTC

⚠️ Flakes

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 2 • Retry 1 • Initial Attempt	15.85% (52) 52 / 328 runs failed over last 7 days	26.22% (86) 86 / 328 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user can add multiple organizer address Retry 1 • Initial Attempt	0.58% (2) 2 / 342 runs failed over last 7 days	10.82% (37) 37 / 342 runs flaked over last 7 days

View Detailed Build Results

alwaysmeticulous · 2023-07-11T20:44:50Z

🤖 Meticulous spotted visual differences in 75 of 203 screens tested: view and approve differences detected.

_{Last updated for commit 90a304e. This comment will update as new commits are pushed.}

ericrommel

Hey @gitstart-calcom, sorry, but unit testing for ui components from a third-party library doesn't make any sense. Can you elaborate on how valuable for us to test them? unit tests are linked to actions on our behaviours, not from external components. We can achieve UI behavioural expectations from the high-level testing part, like UI Testing, Acceptance testing and others that can be even automated. What do you think to discuss about it (if needed)?

gitstart-calcom · 2023-07-12T00:46:29Z

Hi @ericrommel, how are you? 😄
It was discussed in our Slack group about creating these tests and we were allowed to create these PRs, unit tests for UI components offer valuable benefits, even if they come from a third-party library. here are some points that you should consider:

They allow isolated testing of internal logic and behavior specific to the components.
Unit tests provide a faster feedback loop, helping identify and address component-specific issues promptly.
They contribute to overall test coverage and enhance confidence in the codebase's stability and reliability.
Unit tests for UI components complement high-level testing approaches, focusing on internal behaviors.

In summary, incorporating unit tests for UI components in the calcom brings advantages in terms of isolated testing, faster feedback, improved test coverage, and enhanced confidence. What do you think?

…s/credits (calcom#10044) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>

Create RTL tests for Credits component

17a95dd

zomars added the core area: core, team members only label Jul 10, 2023

vercel bot had a problem deploying to Preview – ui July 10, 2023 17:54 Failure

vercel bot deployed to Preview – api July 10, 2023 17:55 View deployment

vercel bot deployed to Preview – cal July 10, 2023 17:58 View deployment

gitstart-calcom marked this pull request as ready for review July 10, 2023 18:51

gitstart-calcom requested review from PeerRich, alannnc, hariombalhara, keithwillcode, sean-brydon and zomars July 10, 2023 18:52

PeerRich added the Low priority Created by Linear-GitHub Sync label Jul 10, 2023

Remove classNames tests

d17d8fe

vercel bot had a problem deploying to Preview – ui July 11, 2023 20:40 Failure

vercel bot deployed to Preview – cal-staging July 11, 2023 20:41 View deployment

vercel bot deployed to Preview – api July 11, 2023 20:41 View deployment

vercel bot deployed to Preview – cal July 11, 2023 20:43 View deployment

ericrommel suggested changes Jul 11, 2023

View reviewed changes

Merge branch 'main' into CALCOM-618

90a304e

gitstart-calcom requested a review from ericrommel July 12, 2023 00:47

vercel bot deployed to Preview – ui July 12, 2023 00:50 View deployment

vercel bot deployed to Preview – api July 12, 2023 00:52 View deployment

vercel bot deployed to Preview – cal July 12, 2023 00:53 View deployment

vercel bot deployed to Preview – cal-staging July 12, 2023 00:54 View deployment

gitstart-calcom added 2 commits July 19, 2023 21:49

Merge branch 'main' into CALCOM-618

7002e89

Update package.json

c03fc2e

vercel bot deployed to Preview – ui July 19, 2023 20:57 View deployment

vercel bot deployed to Preview – dev July 19, 2023 21:01 View deployment

vercel bot deployed to Preview – api July 19, 2023 21:02 View deployment

vercel bot deployed to Preview – cal-demo July 19, 2023 21:03 View deployment

gitstart-calcom changed the title ~~test: Create unit tests for react components in packages/ui/components/credits (CALCOM-618)~~ test: Create unit tests for react components in packages/ui/components/credits Jul 20, 2023

keithwillcode approved these changes Jul 21, 2023

View reviewed changes

keithwillcode merged commit 85c3c6d into main Jul 21, 2023

keithwillcode deleted the CALCOM-618 branch July 21, 2023 16:44

fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023

test: Create unit tests for react components in packages/ui/component…

5ab5cf7

…s/credits (calcom#10044) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>

gitstart-calcom mentioned this pull request Jul 26, 2023

Create unit tests for components #10406

Closed

28 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Create unit tests for react components in packages/ui/components/credits#10044

test: Create unit tests for react components in packages/ui/components/credits#10044
keithwillcode merged 5 commits intomainfrom
CALCOM-618

gitstart-calcom commented Jul 10, 2023 •

edited

Loading

Uh oh!

vercel bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

deploysentinel bot commented Jul 10, 2023 •

edited

Loading

Test Case Results

Test Case Results

Uh oh!

alwaysmeticulous bot commented Jul 11, 2023 •

edited

Loading

Uh oh!

ericrommel left a comment

Uh oh!

gitstart-calcom commented Jul 12, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

gitstart-calcom commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DEMO

Uh oh!

vercel bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Uh oh!

alwaysmeticulous bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericrommel left a comment

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gitstart-calcom commented Jul 10, 2023 •

edited

Loading

vercel bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

deploysentinel bot commented Jul 10, 2023 •

edited

Loading

alwaysmeticulous bot commented Jul 11, 2023 •

edited

Loading

gitstart-calcom commented Jul 12, 2023 •

edited

Loading