Skip to content

feat: unit tests for embed pages#10014

Merged
hariombalhara merged 7 commits intocalcom:mainfrom
Pradumn27:feat/embed-detection-test
Jul 17, 2023
Merged

feat: unit tests for embed pages#10014
hariombalhara merged 7 commits intocalcom:mainfrom
Pradumn27:feat/embed-detection-test

Conversation

@Pradumn27
Copy link
Copy Markdown
Contributor

@Pradumn27 Pradumn27 commented Jul 8, 2023

What does this PR do?

This PR adds e2e tests to check for the styling of the embed page of eventType and also to check whether isEmbed becomes true once we change the window.name property

Fixes #9386
/claim #9386

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Run automated e2e tests

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 7:11am

@algora-pbc algora-pbc bot mentioned this pull request Jul 8, 2023
Closed
@vercel
Copy link
Copy Markdown

vercel bot commented Jul 8, 2023

@Pradumn27 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added automated-tests area: unit tests, e2e tests, playwright Low priority Created by Linear-GitHub Sync 💎 Bounty A bounty on Algora.io 🙋🏻‍♂️help wanted Help from the community is appreciated labels Jul 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@Pradumn27 Pradumn27 changed the title Feat/embed detection test Feat: e2e tests for embed pages Jul 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Pradumn27 Pradumn27 changed the title Feat: e2e tests for embed pages Feat: unit tests for embed pages Jul 9, 2023
@CarinaWolli CarinaWolli requested review from a team July 11, 2023 20:35
@hariombalhara hariombalhara changed the title Feat: unit tests for embed pages feat: unit tests for embed pages Jul 13, 2023
hariombalhara
hariombalhara reviewed Jul 13, 2023
View reviewed changes
apps/web/playwright/embed-pages.e2e.ts
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pradumn27 Let's move this file along with this file in the same folder

cal.com/packages/embeds/embed-core/playwright/tests/action-based.e2e.ts

Line 17 in 3f93e60

addEmbedListeners,

hariombalhara
hariombalhara requested changes Jul 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested one change @Pradumn27 . If tests pass after that it will be good to merge.

@Pradumn27 Pradumn27 requested a review from hariombalhara July 13, 2023 16:23
@Pradumn27
Copy link
Copy Markdown
Contributor Author

Pradumn27 commented Jul 14, 2023

Requested one change @Pradumn27 . If tests pass after that it will be good to merge.

Thanks for the review @hariombalhara ,I have done the requested changes and the tests are passing!

@hariombalhara hariombalhara merged commit 17324e4 into calcom:main Jul 17, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@Pradumn27 @hariombalhara @fritterhoff
feat: unit tests for embed pages (calcom#10014)
db9fc59 
Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees

No one assigned

Labels

automated-tests area: unit tests, e2e tests, playwright 💎 Bounty A bounty on Algora.io 🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-1901] Unit Test: window.isEmbed()

2 participants

@Pradumn27 @hariombalhara