fix for Discussion #4333 (PR as req by Pascal Berger)#352
Merged
nils-a merged 1 commit intocake-contrib:developfrom Sep 29, 2024
DickBaker:develop
Merged
fix for Discussion #4333 (PR as req by Pascal Berger)#352nils-a merged 1 commit intocake-contrib:developfrom DickBaker:develop
nils-a merged 1 commit intocake-contrib:developfrom
DickBaker:develop
Conversation
|
DickBaker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
nils-a
approved these changes
Sep 29, 2024
Contributor
nils-a
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for getting this done.
Contributor
|
@DickBaker thank you for fixing this! |
Author
|
Nils, Hi
Think I did that already (as otherwise CLA wouldn’t have accepted as below).
If I need to do anyfink, you just holler !
Regards,
Dick
From: Nils Andresen ***@***.***>
Sent: 29 September 2024 20:10
To: cake-contrib/CakeContrib.Guidelines ***@***.***>
Cc: Dick Baker ***@***.***>; Mention ***@***.***>
Subject: Re: [cake-contrib/CakeContrib.Guidelines] fix for Discussion #4333 (PR as req by Pascal Berger) (PR #352)
@DickBaker <https://github.com/DickBaker> thank you for fixing this!
Are you in a position to sign the CLA?
—
Reply to this email directly, view it on GitHub <#352 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVFJLG4OEKHHCZPPZL6WZLZZBGCHAVCNFSM6AAAAABO5EYH6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGUZTQNZTG4> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AAVFJLHE7V4O32WYIW7W4VTZZBGCHA5CNFSM6AAAAABO5EYH6WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUN6NS3C.gif> Message ID: ***@***.*** ***@***.***> >
From: CLAassistant ***@***.*** ***@***.***>
Sent: 26 September 2024 15:27
To: cake-contrib/CakeContrib.Guidelines ***@***.*** ***@***.***>
Cc: Dick Baker ***@***.*** ***@***.***> ; Author ***@***.*** ***@***.***>
Subject: Re: [cake-contrib/CakeContrib.Guidelines] fix for Discussion #4333 (PR as req by Pascal Berger) (PR #352)
<https://cla-assistant.io/cake-contrib/CakeContrib.Guidelines?pullRequest=352>
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement <https://cla-assistant.io/cake-contrib/CakeContrib.Guidelines?pullRequest=352> before we can accept your contribution.
…_____
DickBaker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account <https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user> .
You have signed the CLA already but the status is still pending? Let us recheck <https://cla-assistant.io/check/cake-contrib/CakeContrib.Guidelines?pullRequest=352> it.
—
Reply to this email directly, view it on GitHub <#352 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVFJLBKMB7XYLEJRJWEEW3ZYQKRZAVCNFSM6AAAAABO5EYH6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGEZTENZZGM> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/AAVFJLHWCXB2Z55LVFUYXW3ZYQKRZA5CNFSM6AAAAABO5EYH6WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUNWAVPS.gif> Message ID: ***@***.*** ***@***.***>
|
Contributor
|
@DickBaker your changes have been merged, thanks for your contribution 👍 |
cake-contrib-bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
Merge pull request #352 from DickBaker/develop fix for Discussion #4333 (PR as req by Pascal Berger)
|
🎉 This issue has been resolved in version 1.6.0 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor typo fix