Updated TargetFrameworkVersions to match Cake 3.0.0 versions.#218
Updated TargetFrameworkVersions to match Cake 3.0.0 versions.#218nils-a merged 2 commits intocake-contrib:developfrom squid-box:GH-217
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## develop #218 +/- ##
===========================================
+ Coverage 94.27% 94.30% +0.03%
===========================================
Files 14 14
Lines 629 650 +21
Branches 92 94 +2
===========================================
+ Hits 593 613 +20
Misses 16 16
- Partials 20 21 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for working on this. 👍 Looks good at first glance, I'll have a closer look when I can get to a computer. |
|
@squid-box would you also be in a position to update the docs? (Seems I missed those for the 2.0.0 version, too. 😇) |
|
@nils-a: I'm really moving into dangerous territory here, documenting something I'm very vaguely understanding 😄 - but I've made an attempt. I'm not sure if there also needs to be an update to the module version checks for 3.0.0, they're untouched so far (but I did update their documentation as well, for better or worse). |
I'll guide you, I promise 😆
Yes, I'll add some comments to changes you made to the docs. The implementation should reflect that accordingly. I'll have access to a decent computer (rather: keyboard and monitor) on Monday if you need more help than I can provide via mobile. |
To reflect the required TargetFrameworkVersions for Cake version 3.0.0.
To show Cake version 3.0.0 as recommended version.
|
@squid-box Perfect. Thanks for getting this done. I have fixed up the commits a bit (hope you don't mind) and added one additional change (CCG0009 - Suggested Cake version to use) |
|
@squid-box your changes have been merged, thanks for your contribution 👍 |
|
@all-contributors please add @squid-box for code. |
|
I've put up a pull request to add @squid-box! 🎉 |
As noted in #217, the supported frameworks needs to be updated following the release of Cake 3.0.0.
As best as I can tell, this is what was necessary to change - and local tests at least work with the version produced with my changes. I'm very much open to feedback on this, should I have missed/misunderstood something.