Skip to content

Fix "Append" aliases#124

Merged
augustoproiete merged 1 commit intocake-contrib:developfrom
ap0llo:fix-append-aliases
Mar 13, 2023
Merged

Fix "Append" aliases#124
augustoproiete merged 1 commit intocake-contrib:developfrom
ap0llo:fix-append-aliases

Conversation

@ap0llo
Copy link
Copy Markdown
Contributor

@ap0llo ap0llo commented Mar 13, 2023

Description

In the "FileAppend" aliases (FileAppendText and FileAppendLines), open the file stream in file mode "Append" instead of "OpenOrCreate" so that the content is appended to the end of the file instead of (partially) overwriting the file from the beginning

Related Issue

See #123

Motivation and Context

Fixes a bug (#123) introduced by #118

How Has This Been Tested?

The PR adds additional unit tests for the FileAppendText/FileAppendLines aliases

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ap0llo
Fix "Append" aliases
642e396 
In the "FileAppend" aliases (FileAppendText and FileAppendLines), open the file stream in file mode "Append" instead of "OpenOrCreate" so that the content is appended to the end of the file instead of (partially) overwriting the file from the beginning
@augustoproiete augustoproiete self-requested a review March 13, 2023 19:22
@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Mar 13, 2023

Thanks for reporting and fixing the bug @ap0llo!

augustoproiete
augustoproiete approved these changes Mar 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete merged commit b431a17 into cake-contrib:develop Mar 13, 2023
@augustoproiete augustoproiete linked an issue Mar 13, 2023 that may be closed by this pull request
"Append" aliases (partially) overwrite the file instead of appending to it #123
Closed
@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Mar 13, 2023

@ap0llo your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Append" aliases (partially) overwrite the file instead of appending to it

2 participants

@ap0llo @augustoproiete