Use Cake's IFileSystem for read/write operations instead of System.IO.File#118
Merged
augustoproiete merged 3 commits intocake-contrib:developfrom Feb 21, 2023
Merged
Conversation
augustoproiete
requested changes
Feb 20, 2023
Member
augustoproiete
left a comment
There was a problem hiding this comment.
Thanks for the PR @ap0llo! Concept ACK and overall LGTM. Added a couple of minor comments/requests
Contributor
Author
|
Thanks for your review! I applied your suggestions, please let me know if there is anything else you'd like me to adapt. |
….File In all file aliases, use Cake's IFileSystem abstraction instead of using System.IO.File. This enables testing of tasks that use the file aliases by mocking IFileSystem. The FileTouch() alias continues to use System.IO.File since there is no API in IFileSystem that allows setting the last write time.
Co-authored-by: C. Augusto Proiete <augusto@proiete.com>
Co-authored-by: C. Augusto Proiete <augusto@proiete.com>
76c4633 to
9ca052b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In all file aliases, use Cake's IFileSystem abstraction instead of using System.IO.File.
This enables testing of tasks that use the file aliases by mocking IFileSystem.
The FileTouch() alias continues to use System.IO.File since there is no API in IFileSystem that allows setting the last write time.
Related Issue
This PR fixes #117
Motivation and Context
See #117. This enables mocking of the file system in tests for tasks
How Has This Been Tested?
All tests in the project are still passing
Types of changes
Checklist: