Conversation
josuave
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, FullScreenHelper will only remove a full-screen window from the full-screen windows list if it is no longer full-screen or if it has moved to another monitor. This means that a window obstructing it does not remove it from the full-screen list.
This changes the logic to instead only keep a window in the full-screen windows list in two scenarios:
Effectively this means that full-screen windows will stay in the full-screen list unless they are obstructed, which is the desired behavior.
This should fix cairoshell/cairoshell#495 and dremin/RetroBar#171.